From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH] Rename 'start_wispr_when_connected'.
Date: Thu, 19 Oct 2023 14:39:55 -0700 [thread overview]
Message-ID: <D769C836-3C52-4615-A17A-8CACAD0B0AE3@nuovations.com> (raw)
The current name implies that a deferred action is "hooked" and that when
the service becomes "connected"; a WISPr-based reachability probe will
start. The revised name, 'start_wispr_if_connected' implies, correctly,
a one-shot chance to start WISPr if the service is "connected" at the
time of the call.
---
src/service.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/service.c b/src/service.c
index 06d02322..31fe8917 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1602,7 +1602,7 @@ bool __connman_service_index_is_default(int index)
return __connman_service_get_index(service) == index;
}
-static void start_wispr_when_connected(struct connman_service *service)
+static void start_wispr_if_connected(struct connman_service *service)
{
if (!connman_setting_get_bool("EnableOnlineCheck")) {
connman_info("Online check disabled. "
@@ -1645,7 +1645,7 @@ static void default_changed(void)
connman_setting_get_bool("AllowDomainnameUpdates"))
__connman_utsname_set_domainname(service->domainname);
- start_wispr_when_connected(service);
+ start_wispr_if_connected(service);
/*
* Connect VPN automatically when new default service
@@ -3748,7 +3748,7 @@ static DBusMessage *set_property(DBusConnection *conn,
nameserver_add_all(service, CONNMAN_IPCONFIG_TYPE_ALL);
dns_configuration_changed(service);
- start_wispr_when_connected(service);
+ start_wispr_if_connected(service);
service_save(service);
} else if (g_str_equal(name, "Timeservers.Configuration")) {
--
2.32.0
next reply other threads:[~2023-10-19 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 21:39 Grant Erickson [this message]
2023-11-07 15:14 ` [PATCH] Rename 'start_wispr_when_connected' Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D769C836-3C52-4615-A17A-8CACAD0B0AE3@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).