From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] service: Qualify call to '__connman_timeserver_sync' with default check.
Date: Sat, 23 Dec 2023 13:20:20 +0100 [thread overview]
Message-ID: <B3B1E61A-267E-4A6F-BF3A-AD5A63B86A4E@holtmann.org> (raw)
In-Reply-To: <20231220012437.2259325-1-gerickson@nuovations.com>
Hi Grant,
> This qualifies the call to '__connman_timeserver_sync' in
> '__connman_service_ipconfig_indicate_state' with a check against
> 'connman_service_is_default'.
>
> In a multi-technology and -service environment, there may be a senior,
> default service that is providing the network service for time-of-day
> synchronization.
>
> Without the 'connman_service_is_default' qualification, in a
> multi-technology and -service environment, as junior services
> transitions to the 'ready' state, each of those service usurp the
> senior, default service and start trying to provide time-of-day
> synchronization which is NOT what is desired.
>
> So, in a configuration with Ethernet, Wi-Fi, and Cellular in which
> they are preferred in that order and in which Ethernet is the default
> and becomes 'ready' first, Ethernet will provide the network service
> for time-of-day synchronization. Then, once Wi-Fi becomes 'ready', it
> will usurp time-of-day synchronization from Ethernet. Similarly, when
> Cellular becomes 'ready' it will usurp time-of-day synchronization
> from Wi-Fi. In all of those cases, time-of-day synchronization should
> have remained with Ethernet until such time as it was/is no longer the
> senior, default service.
> ---
> src/service.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-12-23 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 1:24 [PATCH] service: Qualify call to '__connman_timeserver_sync' with default check Grant Erickson
2023-12-23 12:20 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B3B1E61A-267E-4A6F-BF3A-AD5A63B86A4E@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).