From: Marcel Holtmann <marcel@holtmann.org>
To: Nicolas Gariepy <ngariepy1999@gmail.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] resolver: FIX path to resolv.conf config option
Date: Tue, 7 Nov 2023 16:33:32 +0100 [thread overview]
Message-ID: <ADA17299-4A4F-46F7-929A-E4ADDBF03784@holtmann.org> (raw)
In-Reply-To: <20230929033408.80874-1-ngariepy1999@gmail.com>
Hi Nicolas,
> There are two problems with how the "ResolvConf" option was implemented.
>
> 1. The "ResolvConf" is used in src/resolver.c using the function connman_setting_get_string(const char *key) but the connman_settings.resolv_conf option could only be accessed using the connman_setting_get_bool(const char *key) function at the moment.
> 2. The Gerror is not cleared before trying to read the "ResolvConf" parameter of the config.
>
> This patch fixes the two issues above.
> ---
> src/main.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 3:34 [PATCH] resolver: FIX path to resolv.conf config option Nicolas Gariepy
2023-10-23 14:52 ` Grant Erickson
2023-11-01 20:59 ` Grant Erickson
2023-11-07 15:33 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ADA17299-4A4F-46F7-929A-E4ADDBF03784@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=ngariepy1999@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).