From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 0/2] inet: Add and Document '__connman_inet_rtnl_recv'.
Date: Fri, 15 Dec 2023 09:45:27 +0100 [thread overview]
Message-ID: <A7DBC6AC-01FA-45BD-AA57-4A41D1CE2606@holtmann.org> (raw)
In-Reply-To: <20231214172712.2083929-1-gerickson@nuovations.com>
Hi Grant,
> This refactors the private, file-scope interface 'inet_rtnl_recv' into
> a separate semi-public, project-scope interface
> '__connman_inet_rtnl_recv'.
>
> Currently, 'inet_rtnl_recv' is intended to be used as a glib runloop
> helper in conjunction with '__connman_inet_rtnl_talk' for longer or
> multi-phase Routing Netlink (rtnl) interactions.
>
> However, for short, concise open/send/recv/close Routing Netlink
> (rtnl) interactions in which there is a single request/response phase
> or the complexity of an asynchronous run loop interaction is not
> needed, there is not an appropriate 'recv' interface to peer with
> open/send/close.
>
> With this change, the core of 'inet_rtnl_recv' is factored out into
> that missing 'recv' interface, '__connman_inet_rtnl_recv' with
> 'inet_rtnl_recv' invoking it.
>
> Grant Erickson (2):
> inet: Add '__connman_inet_rtnl_recv'.
> connection: Document '__connman_inet_rtnl_recv'.
>
> src/connman.h | 3 +-
> src/inet.c | 87 ++++++++++++++++++++++++++++++++++++++++++---------
> 2 files changed, 75 insertions(+), 15 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-12-15 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 17:27 [PATCH 0/2] inet: Add and Document '__connman_inet_rtnl_recv' Grant Erickson
2023-12-14 17:27 ` [PATCH 1/2] inet: Add '__connman_inet_rtnl_recv' Grant Erickson
2023-12-14 17:27 ` [PATCH 2/2] connection: Document '__connman_inet_rtnl_recv' Grant Erickson
2023-12-15 8:45 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A7DBC6AC-01FA-45BD-AA57-4A41D1CE2606@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).