From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] ipconfig: Return a unique string for 'CONNMAN_IPCONFIG_TYPE_ALL'.
Date: Wed, 29 Nov 2023 13:54:26 +0100 [thread overview]
Message-ID: <A466F688-5620-4015-A606-4F3EAEA2697F@holtmann.org> (raw)
In-Reply-To: <20231128181551.1149522-1-gerickson@nuovations.com>
Hi Grant,
> At commit 89f70d225df6 ("ipconfig: Define unique value for
> CONNMAN_IPCONFIG_TYPE_ALL"), a unique enumertion value was provided
> for 'CONNMAN_IPCONFIG_TYPE_ALL' to make it semantically different from
> 'CONNMAN_IPCONFIG_TYPE_ALL'; however, a unique string returned
> from '__connman_ipconfig_type2string' was not, leaving it to misleadingly
> return "unknown" for 'CONNMAN_IPCONFIG_TYPE_ALL'.
>
> This addresses this oversight by returning a unique string for
> 'CONNMAN_IPCONFIG_TYPE_ALL', "IPv4 + IPv6".
> ---
> src/ipconfig.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-29 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 18:15 [PATCH] ipconfig: Return a unique string for 'CONNMAN_IPCONFIG_TYPE_ALL' Grant Erickson
2023-11-29 12:54 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A466F688-5620-4015-A606-4F3EAEA2697F@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).