From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH] Expand DBG content in WISPr functions.
Date: Thu, 19 Oct 2023 15:13:04 -0700 [thread overview]
Message-ID: <98B224A1-A428-4C45-BB8C-4C2679C65706@nuovations.com> (raw)
As the functionality for "EnableOnlineToReadyTransition" is further
developecd and there are multiple online checks in flight for multiple
services and IP configuration types thereof, the expanded content in
these DBG statements becomes critical to successfully tracking these
unique online check operations.
---
src/wispr.c | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/src/wispr.c b/src/wispr.c
index 2ed4d440..f9413371 100644
--- a/src/wispr.c
+++ b/src/wispr.c
@@ -538,8 +538,11 @@ static bool wispr_route_request(const char *address, int ai_family,
static void wispr_portal_request_portal(
struct connman_wispr_portal_context *wp_context)
{
- DBG("wp_context %p %s", wp_context,
- __connman_ipconfig_type2string(wp_context->type));
+ DBG("wispr/portal context %p service %p (%s) type %d (%s)",
+ wp_context,
+ wp_context->service,
+ connman_service_get_identifier(wp_context->service),
+ wp_context->type, __connman_ipconfig_type2string(wp_context->type));
wispr_portal_context_ref(wp_context);
wp_context->request_id = g_web_request_get(wp_context->web,
@@ -932,8 +935,11 @@ static int wispr_portal_detect(struct connman_wispr_portal_context *wp_context)
int err = 0;
int i;
- DBG("wispr/portal context %p service %p", wp_context,
- wp_context->service);
+ DBG("wispr/portal context %p service %p (%s) type %d (%s)",
+ wp_context,
+ wp_context->service,
+ connman_service_get_identifier(wp_context->service),
+ wp_context->type, __connman_ipconfig_type2string(wp_context->type));
interface = connman_service_get_interface(wp_context->service);
if (!interface)
@@ -1009,8 +1015,10 @@ int __connman_wispr_start(struct connman_service *service,
struct connman_wispr_portal *wispr_portal = NULL;
int index, err;
- DBG("service %p %s callback %p", service,
- __connman_ipconfig_type2string(type), callback);
+ DBG("service %p (%s) type %d (%s) callback %p",
+ service, connman_service_get_identifier(service),
+ type, __connman_ipconfig_type2string(type),
+ callback);
if (!wispr_portal_hash || !callback)
return -EINVAL;
@@ -1087,7 +1095,7 @@ void __connman_wispr_stop(struct connman_service *service)
struct connman_wispr_portal *wispr_portal;
int index;
- DBG("service %p", service);
+ DBG("service %p (%s)", service, connman_service_get_identifier(service));
if (!wispr_portal_hash)
return;
--
2.32.0
next reply other threads:[~2023-10-19 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 22:13 Grant Erickson [this message]
2023-11-02 18:47 ` [PATCH v2] Expand DBG content in WISPr 'wispr_portal_request_portal' Grant Erickson
2023-11-07 16:01 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98B224A1-A428-4C45-BB8C-4C2679C65706@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).