From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v3 00/60] Complete 'continuous' Online Check Mode Implementation.
Date: Sat, 23 Dec 2023 13:22:42 +0100 [thread overview]
Message-ID: <81F7E5E9-9028-46FD-9967-A3B755271079@holtmann.org> (raw)
In-Reply-To: <20231221223508.2365510-1-gerickson@nuovations.com>
Hi Grant,
> This completes the implementation of 'EnableOnlineToReadyTransition'
> begun by Emmanuel Vautrin with commit f0bd0e8fe578 ("service: Add
> online to ready transition feature").
>
> When asserted along with 'EnableOnlineCheck',
> 'EnableOnlineToReadyTransition' effects what can be thought of as a
> "continuous" online check mode, which is different from the "one-shot"
> online check mode when 'EnableOnlineToReadyTransition' is not asserted
> but 'EnableOnlineCheck' is. Effectively, these two Booleans encode
> three online check modes:
>
> 1. None (!EnableOnlineCheck)
> 2. One-shot (EnableOnlineCheck && !EnableOnlineToReadyTransition)
> 3. Continuous (EnableOnlineCheck && EnableOnlineToReadyTransition)
>
> With this change, these three modes are formalized and introduced as a
> new 'OnlineCheckMode' configuration setting which is intended to
> eventually deprecate 'EnableOnlineCheck' (long-term) and
> 'EnableOnlineToReadyTransition' (short-term, as it never made it
> beyond the EXPERIMENTAL designation).
>
> In "none" mode, as has been the case historically, there are no
> "online" HTTP-based Internet reachability checks. Any connected
> service and the manager state will terminate at the "ready" state and
> will not progress to "online".
>
> In "one-shot" mode, as has been the case historically, there is a
> single, one-shot "online" HTTP-based Internet reachability check for
> the default service. When the check succeeds, the associated service
> and the manager state will terminate at the "online" state. When the
> check fails, subsequent checks will be rescheduled according to
> "OnlineCheckIntervalStyle", "OnlineCheckInitialInterval", and
> "OnlineCheckMaxInterval" and will continue indefinitely until one
> succeeds or until the service is disconnected.
>
> In "continuous" mode, which is finalized with this change, there are
> ongoing "online" HTTP-based Internet reachability check for the
> default service. As with "one-shot" mode, when the first check
> succeeds, the associated service and the manager state will terminate
> at the "online" state. Thereafter, subsequent checks will be scheduled
> according to "OnlineCheckIntervalStyle" and
> "OnlineCheckMaxInterval". When the check fails, subsequent checks will
> be rescheduled according to "OnlineCheckIntervalStyle",
> "OnlineCheckInitialInterval", and "OnlineCheckMaxInterval". This is
> largely unchanged. However, what is new with this change is that when
> and if "OnlineCheckFailuresThreshold" is met, the service and manager
> state will be demoted to "ready" and the service will have its "Error"
> property set to "online-check-failed" while subsequent checks will
> continue. In the interim, if available, another service may be
> promoted to the default service and online checks will be initiated
> for it. When and if, for the demoted service,
> "OnlineCheckSuccessesThreshold" is met, the service "Error" property
> will be cleared and the service state promoted to "online",
> potentially causing it to become the default service again.
>
> Grant Erickson (60):
> service: Change return type of '__connman_service_wispr_start'.
> service: Sanity check the 'type' param in
> '__connman_service_wispr_start'.
> service: Rename 'online_check_enabled_check'.
> service: Change return type of 'start_online_check'.
> service: Change return type of 'start_wispr_if_connected'.
> service: Introduce and use online check 'active' state.
> service: Document 'online_check_state' 'active' member.
> service: Document 'online_check_is_active'.
> service: Document 'online_check_active_set_value'.
> service: Document 'online_check_active_{clear,set}'.
> service: Rename 'start_wispr_if_connected'.
> service: Refactor 'start_online_check_if_connected'.
> service: Document 'start_online_check_if_connected_with_type'.
> service: Add an explicit conditional for IPv6 in
> 'reschedule_online_check'.
> session: Add service identifier to 'DBG' in four functions.
> service: Add online check failure service error enumeration and
> string.
> doc/service: Document online check failure service error.
> service: Introduce and use online check 'failures/successes' state.
> service: Document 'online_check_state' 'failures/successes' members.
> main: Introduce the 'OnlineCheck{Failures,Successes}Threshold'
> settings.
> doc: Document the 'OnlineCheck{Failures,Successes}Threshold' settings.
> service: Add per-service online check failure threshold state.
> service: Document 'connman_service'
> 'online_check_failures_met_threshold' member.
> service: Document 'connman_service' 'online_check_state_ipv{4,6}'
> members.
> service: Move 'set_error' forward declaration earlier in the source.
> service: Capture IP configuration state by value rather than by
> pointer.
> service: Complete 'continuous' online check mode implementation.
> service: Document 'online_check_failures_threshold_was_met'.
> service: Document 'online_check_failures_threshold_was_met_set_value'.
> service: Document
> 'online_check_failures_threshold_was_met_{set,clear}'.
> service: Document 'online_check_counter_reset'.
> service: Document 'online_check_{failures,successes}_reset'.
> service: Document 'online_check_state_reset'.
> service: Document 'online_check_counters_log'.
> service: Document 'online_check_counter_threshold_is_met'.
> service: Document 'is_online_check_failure_threshold_met_predicate'.
> service: Document 'online_check_failures_threshold_is_met'.
> service: Document 'is_online_check_success_threshold_met_predicate'.
> service: Document 'online_check_successes_threshold_is_met'.
> service: Document 'online_check_counter_increment_and_log'.
> service: Document 'online_check_log_success'.
> service: Document
> 'continuous_online_check_log_{counter,failures,successes}_threshold_met'.
> service: Document 'handle_{continuous,oneshot}_online_check_success'.
> service: Document 'online_check_log_failure'.
> service: Document 'handle_{continuous,oneshot}_online_check_failure'.
> service: Add @sa documentation references.
> service: Document the internals of 'service_compare'.
> service: Document interval assignment in
> '__connman_service_wispr_start'.
> service: Document 'downgrade_connected_services'.
> service: Document 'service_schedule_changed'.
> service: Document 'service_route_changed'.
> service: Add function parameter to 'default_changed' and
> 'service_list_sort'.
> service: Add @sa documentation reference to 'current_default'.
> service: Add 'DBG' to 'downgrade_connected_services'.
> main/service: Introduce 'OnlineCheckMode' setting.
> service: Leverage 'OnlineCheckMode' setting.
> doc: Document the 'OnlineCheckMode' setting.
> main: Add comments tags for online check-related settings.
> main: Consolidate logging of online check-related settings.
> main: Add deprecation warnings for 'EnableOnlineCheck' and
> 'EnableOnlineToReadyTransition'.
>
> README | 91 +-
> doc/connman.conf.5.in | 85 +-
> doc/service-api.txt | 3 +-
> include/service.h | 26 +-
> src/connman.h | 18 +-
> src/main.c | 177 +++-
> src/main.conf | 122 ++-
> src/service.c | 2133 ++++++++++++++++++++++++++++++++++++-----
> 8 files changed, 2356 insertions(+), 299 deletions(-)
all SIXTY (60 ;) patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2023-12-23 12:22 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 22:34 [PATCH v3 00/60] Complete 'continuous' Online Check Mode Implementation Grant Erickson
2023-12-21 22:34 ` [PATCH v3 01/60] service: Change return type of '__connman_service_wispr_start' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 02/60] service: Sanity check the 'type' param in '__connman_service_wispr_start' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 03/60] service: Rename 'online_check_enabled_check' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 04/60] service: Change return type of 'start_online_check' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 05/60] service: Change return type of 'start_wispr_if_connected' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 06/60] service: Introduce and use online check 'active' state Grant Erickson
2023-12-21 22:34 ` [PATCH v3 07/60] service: Document 'online_check_state' 'active' member Grant Erickson
2023-12-21 22:34 ` [PATCH v3 08/60] service: Document 'online_check_is_active' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 09/60] service: Document 'online_check_active_set_value' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 10/60] service: Document 'online_check_active_{clear,set}' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 11/60] service: Rename 'start_wispr_if_connected' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 12/60] service: Refactor 'start_online_check_if_connected' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 13/60] service: Document 'start_online_check_if_connected_with_type' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 14/60] service: Add an explicit conditional for IPv6 in 'reschedule_online_check' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 15/60] session: Add service identifier to 'DBG' in four functions Grant Erickson
2023-12-21 22:34 ` [PATCH v3 16/60] service: Add online check failure service error enumeration and string Grant Erickson
2023-12-21 22:34 ` [PATCH v3 17/60] doc/service: Document online check failure service error Grant Erickson
2023-12-21 22:34 ` [PATCH v3 18/60] service: Introduce and use online check 'failures/successes' state Grant Erickson
2023-12-21 22:34 ` [PATCH v3 19/60] service: Document 'online_check_state' 'failures/successes' members Grant Erickson
2023-12-21 22:34 ` [PATCH v3 20/60] main: Introduce the 'OnlineCheck{Failures,Successes}Threshold' settings Grant Erickson
2023-12-21 22:34 ` [PATCH v3 21/60] doc: Document " Grant Erickson
2023-12-21 22:34 ` [PATCH v3 22/60] service: Add per-service online check failure threshold state Grant Erickson
2023-12-21 22:34 ` [PATCH v3 23/60] service: Document 'connman_service' 'online_check_failures_met_threshold' member Grant Erickson
2023-12-21 22:34 ` [PATCH v3 24/60] service: Document 'connman_service' 'online_check_state_ipv{4,6}' members Grant Erickson
2023-12-21 22:34 ` [PATCH v3 25/60] service: Move 'set_error' forward declaration earlier in the source Grant Erickson
2023-12-21 22:34 ` [PATCH v3 26/60] service: Capture IP configuration state by value rather than by pointer Grant Erickson
2023-12-21 22:34 ` [PATCH v3 27/60] service: Complete 'continuous' online check mode implementation Grant Erickson
2023-12-21 22:34 ` [PATCH v3 28/60] service: Document 'online_check_failures_threshold_was_met' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 29/60] service: Document 'online_check_failures_threshold_was_met_set_value' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 30/60] service: Document 'online_check_failures_threshold_was_met_{set,clear}' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 31/60] service: Document 'online_check_counter_reset' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 32/60] service: Document 'online_check_{failures,successes}_reset' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 33/60] service: Document 'online_check_state_reset' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 34/60] service: Document 'online_check_counters_log' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 35/60] service: Document 'online_check_counter_threshold_is_met' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 36/60] service: Document 'is_online_check_failure_threshold_met_predicate' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 37/60] service: Document 'online_check_failures_threshold_is_met' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 38/60] service: Document 'is_online_check_success_threshold_met_predicate' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 39/60] service: Document 'online_check_successes_threshold_is_met' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 40/60] service: Document 'online_check_counter_increment_and_log' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 41/60] service: Document 'online_check_log_success' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 42/60] service: Document 'continuous_online_check_log_{counter,failures,successes}_threshold_met' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 43/60] service: Document 'handle_{continuous,oneshot}_online_check_success' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 44/60] service: Document 'online_check_log_failure' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 45/60] service: Document 'handle_{continuous,oneshot}_online_check_failure' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 46/60] service: Add @sa documentation references Grant Erickson
2023-12-21 22:34 ` [PATCH v3 47/60] service: Document the internals of 'service_compare' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 48/60] service: Document interval assignment in '__connman_service_wispr_start' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 49/60] service: Document 'downgrade_connected_services' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 50/60] service: Document 'service_schedule_changed' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 51/60] service: Document 'service_route_changed' Grant Erickson
2023-12-21 22:34 ` [PATCH v3 52/60] service: Add function parameter to 'default_changed' and 'service_list_sort' Grant Erickson
2023-12-21 22:35 ` [PATCH v3 53/60] service: Add @sa documentation reference to 'current_default' Grant Erickson
2023-12-21 22:35 ` [PATCH v3 54/60] service: Add 'DBG' to 'downgrade_connected_services' Grant Erickson
2023-12-21 22:35 ` [PATCH v3 55/60] main/service: Introduce 'OnlineCheckMode' setting Grant Erickson
2023-12-21 22:35 ` [PATCH v3 56/60] service: Leverage " Grant Erickson
2023-12-21 22:35 ` [PATCH v3 57/60] doc: Document the " Grant Erickson
2023-12-21 22:35 ` [PATCH v3 58/60] main: Add comments tags for online check-related settings Grant Erickson
2023-12-21 22:35 ` [PATCH v3 59/60] main: Consolidate logging of " Grant Erickson
2023-12-21 22:35 ` [PATCH v3 60/60] main: Add deprecation warnings for 'EnableOnlineCheck' and 'EnableOnlineToReadyTransition' Grant Erickson
2023-12-23 12:22 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81F7E5E9-9028-46FD-9967-A3B755271079@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).