From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v3] Const-qualify service leaf getter functions.
Date: Tue, 7 Nov 2023 20:08:25 +0100 [thread overview]
Message-ID: <7AA1FB84-5EC6-4891-B788-EB179DF272AC@holtmann.org> (raw)
In-Reply-To: <A40BC348-646B-48D2-B011-E9627522946A@nuovations.com>
Hi Grant,
> Const-qualify the network service arguments in service leaf getter
> and introspection functions to make it clear to the compiler, static
> analyzers, and human readers that the function is strictly a getter
> or introspection function with no network service mutation side
> effects.
> ---
> include/service.h | 18 +++++++++---------
> src/connman.h | 22 +++++++++++-----------
> src/service.c | 40 ++++++++++++++++++++--------------------
> 3 files changed, 40 insertions(+), 40 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 21:34 [PATCH] Const-qualify service leaf getter functions Grant Erickson
2023-11-01 23:48 ` [PATCH v2] " Grant Erickson
2023-11-07 15:37 ` Marcel Holtmann
2023-11-07 18:43 ` Grant Erickson
2023-11-07 18:41 ` [PATCH v3] " Grant Erickson
2023-11-07 19:08 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AA1FB84-5EC6-4891-B788-EB179DF272AC@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).