From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2] Const-qualify 'service' arguments in name and time server getters.
Date: Wed, 8 Nov 2023 15:35:49 +0100 [thread overview]
Message-ID: <687E4CB8-AF16-43A0-B51A-CD9EA27C0896@holtmann.org> (raw)
In-Reply-To: <D9B864AE-58A6-4384-8FA1-60F2B28B29F0@nuovations.com>
Hi Grant,
> Const-qualify the 'service' arguments in name and time server getter
> functions to make it clear to the compiler, static analyzers,
> and human readers that there are no mutation side effects with
> such arguments and that the returned results are immutable and must
> be copied if mutation is desired.
> ---
> include/service.h | 6 +++---
> src/connman.h | 2 +-
> src/service.c | 10 +++++-----
> src/timeserver.c | 14 +++++++-------
> 4 files changed, 16 insertions(+), 16 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-08 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 17:03 [PATCH] Const-qualify 'service' arguments in name and time server getters Grant Erickson
2023-11-07 15:58 ` Marcel Holtmann
2023-11-07 19:38 ` Grant Erickson
2023-11-07 19:38 ` [PATCH v2] " Grant Erickson
2023-11-08 14:35 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687E4CB8-AF16-43A0-B51A-CD9EA27C0896@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).