From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 00/11] service/wispr: Add Per-service-unique WISPr Host Route Metric/Priority
Date: Sat, 16 Dec 2023 19:46:56 +0100 [thread overview]
Message-ID: <671647AE-51D4-4B49-BA7D-6001827F99EC@holtmann.org> (raw)
In-Reply-To: <20231216061223.2199037-1-gerickson@nuovations.com>
Hi Grant,
> This add and leverages '__connman_service_get_route_metric' to select
> an appropriate service-specific route metric/priority when adding or
> deleting WISPr host routes.
>
> This allows multiple such routes to coexist simultaneously, supporting
> "continuous" mode online checks in which one or more services may be
> conducting "online" WISPr-based Internet reachability checks as they
> move in and out of reachability success/failure.
>
> '__connman_service_get_route_metric' is a non-public service
> interface, which attempts to get the route metric/priority for the
> specified service based on the current service and services state.
>
> If the service is the default or if it is the only service, then the
> metric is zero (0). Otherwise, a low-priority metric (metric > 0)
> unique to the service and its underlying network interface is computed
> and returned.
>
> Grant Erickson (11):
> service: Add '__connman_service_get_route_metric'.
> service: Document '__connman_service_get_route_metric'.
> wispr: Expand 'DBG' in 'wispr_portal_detect'.
> wispr: Add 'DBG' to '__connman_wispr_start' error path.
> wispr: Update 'DBG' in '__connman_wispr_start'.
> wispr: Refactor 'free_wispr_routes'.
> wispr: Simplify IPv4 vs. IPv6 host route management.
> wispr: Document 'free_wispr_route{,s}'.
> wispr: Document 'wispr_route'.
> wispr: Document 'wispr_portal_context_route_ops'.
> wispr: Leverage '__connman_service_get_route_metric'.
>
> src/connman.h | 2 +
> src/service.c | 98 ++++++++++++++++++++++++
> src/wispr.c | 207 +++++++++++++++++++++++++++++++++++++++++---------
> 3 files changed, 271 insertions(+), 36 deletions(-)
all 11 patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2023-12-16 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 6:12 [PATCH 00/11] service/wispr: Add Per-service-unique WISPr Host Route Metric/Priority Grant Erickson
2023-12-16 6:12 ` [PATCH 01/11] service: Add '__connman_service_get_route_metric' Grant Erickson
2023-12-16 6:12 ` [PATCH 02/11] service: Document '__connman_service_get_route_metric' Grant Erickson
2023-12-16 6:12 ` [PATCH 03/11] wispr: Expand 'DBG' in 'wispr_portal_detect' Grant Erickson
2023-12-16 6:12 ` [PATCH 04/11] wispr: Add 'DBG' to '__connman_wispr_start' error path Grant Erickson
2023-12-16 6:12 ` [PATCH 05/11] wispr: Update 'DBG' in '__connman_wispr_start' Grant Erickson
2023-12-16 6:12 ` [PATCH 06/11] wispr: Refactor 'free_wispr_routes' Grant Erickson
2023-12-16 6:12 ` [PATCH 07/11] wispr: Simplify IPv4 vs. IPv6 host route management Grant Erickson
2023-12-16 6:12 ` [PATCH 08/11] wispr: Document 'free_wispr_route{,s}' Grant Erickson
2023-12-16 6:12 ` [PATCH 09/11] wispr: Document 'wispr_route' Grant Erickson
2023-12-16 6:12 ` [PATCH 10/11] wispr: Document 'wispr_portal_context_route_ops' Grant Erickson
2023-12-16 6:12 ` [PATCH 11/11] wispr: Leverage '__connman_service_get_route_metric' Grant Erickson
2023-12-16 18:46 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=671647AE-51D4-4B49-BA7D-6001827F99EC@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).