From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] service: Deduplicate online check config query and log.
Date: Tue, 7 Nov 2023 20:02:22 +0100 [thread overview]
Message-ID: <5BA54FB2-84F4-447E-B303-5D50D019E62E@holtmann.org> (raw)
In-Reply-To: <C6B61007-3C60-43AC-86FC-9C3412A5613A@nuovations.com>
Hi Grant,
> Identical logic with an identical log statement was used in both
> 'start_online_check' and 'start_wispr_if_connected'. This deduplicates
> that code into a single common, file-scope function,
> 'online_check_enabled_check', and leverages it in the two locations it
> was previously duplicated in.
> ---
> src/service.c | 42 ++++++++++++++++++++++++++++++++++--------
> 1 file changed, 34 insertions(+), 8 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:33 [PATCH] service: Deduplicate online check config query and log Grant Erickson
2023-11-07 19:02 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BA54FB2-84F4-447E-B303-5D50D019E62E@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).