From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] Address -Werror=implicit-fallthrough compilation errors.
Date: Tue, 7 Nov 2023 16:32:22 +0100 [thread overview]
Message-ID: <50191017-78F7-4A8F-927D-C240DA2AC8BD@holtmann.org> (raw)
In-Reply-To: <B77C1AEA-B348-4E93-BF9D-DBD10518C0F8@nuovations.com>
Hi Grant,
> This addresses -Werror=implicit-fallthrough compilation errors
> surfaced by GCC when --enable-maintainer-mode is asserted
> by using an explicit connman_iptables_entry_is_valid function
> rather than a copied-and-pasted switch statement with the
> inherent implicit fall through behavior.
>
> ---
> src/iptables.c | 47 ++++++++++++++++-------------------------------
> 1 file changed, 16 insertions(+), 31 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 5:22 [PATCH] Address -Werror=implicit-fallthrough compilation errors Grant Erickson
2023-11-01 5:35 ` [PATCH v2] " Grant Erickson
2023-11-07 15:32 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50191017-78F7-4A8F-927D-C240DA2AC8BD@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).