ConnMan network manager
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] service: Leverage 'is_connected'.
Date: Tue, 7 Nov 2023 17:04:05 +0100	[thread overview]
Message-ID: <4E9DA3BD-4F0A-43B9-A193-5B9E890192A4@holtmann.org> (raw)
In-Reply-To: <7F1AE24F-502C-4A3C-95A8-13602CDB0048@nuovations.com>

Hi Grant,

> In all instances but one where there are checks to see whether the
> IPv4 or IPv6 service state is 'CONNMAN_SERVICE_STATE_READY' or
> 'CONNMAN_SERVICE_STATE_ONLINE', the 'is_connected' function is used.
> This leverages 'is_connected' for the only instance where that was
> not the case.
> ---
> src/service.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

patch has been applied.

Regards

Marcel


      reply	other threads:[~2023-11-07 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 21:59 [PATCH] service: Leverage 'is_connected' Grant Erickson
2023-11-07 16:04 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9DA3BD-4F0A-43B9-A193-5B9E890192A4@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=connman@lists.linux.dev \
    --cc=gerickson@nuovations.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).