From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2 0/3] connection: Introduce and Leverage IP Any / Unspecified Address String Constants and Functions
Date: Fri, 8 Dec 2023 00:46:00 +0100 [thread overview]
Message-ID: <4BBFCA9A-B3DC-47B4-B110-241D5489617B@holtmann.org> (raw)
In-Reply-To: <20231129204156.1298225-1-gerickson@nuovations.com>
Hi Grant,
> The IPv4 and IPv6 any / unspecified address string literals, "0.0.0.0"
> and "::" respectively, and comparisons against them appear often
> enough throughout the code where they warrant referencing through
> file-scoped constants and introducing and leveraging introspection
> functions to encapsulate the comparison patterns.
>
> This introduces and uses such constants and 'is_ipv[46]_addr_any_str'
> introspection functions to encapsulate these comparison patterns.
>
> Grant Erickson (3):
> connection: Introduce and leverage 'ipv[46]_addr_any_str' constants.
> connection: Introduce and leverage 'is_ipv[46]_addr_any_str'
> functions.
> connection: Document 'is_ipv[46]_addr_any_str'.
>
> src/connection.c | 92 ++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 73 insertions(+), 19 deletions(-)
all 3 patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2023-12-07 23:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 1:52 [PATCH 0/3] connection: Introduce and Leverage IP Any / Unspecified Address String Constants and Functions Grant Erickson
2023-11-29 1:52 ` [PATCH 1/3] connection: Introduce and leverage 'ipv[46]_addr_any_str' constants Grant Erickson
2023-11-29 13:19 ` Marcel Holtmann
2023-11-29 17:20 ` Grant Erickson
2023-11-29 17:58 ` Marcel Holtmann
2023-11-29 18:02 ` Grant Erickson
2023-11-29 20:42 ` Grant Erickson
2023-11-29 1:52 ` [PATCH 2/3] connection: Introduce and leverage 'is_ipv[46]_addr_any_str' functions Grant Erickson
2023-11-29 1:52 ` [PATCH 3/3] connection: Document 'is_ipv[46]_addr_any_str' Grant Erickson
2023-11-29 20:41 ` [PATCH v2 0/3] connection: Introduce and Leverage IP Any / Unspecified Address String Constants and Functions Grant Erickson
2023-11-29 20:41 ` [PATCH v2 1/3] connection: Introduce and leverage 'ipv[46]_addr_any_str' constants Grant Erickson
2023-11-29 20:41 ` [PATCH v2 2/3] connection: Introduce and leverage 'is_ipv[46]_addr_any_str' functions Grant Erickson
2023-11-29 20:41 ` [PATCH v2 3/3] connection: Document 'is_ipv[46]_addr_any_str' Grant Erickson
2023-12-07 23:46 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBFCA9A-B3DC-47B4-B110-241D5489617B@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).