From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 0/2] service: Add and Leverage 'clear_error'
Date: Thu, 23 Nov 2023 12:27:27 +0100 [thread overview]
Message-ID: <3F401339-13B4-47D2-9FDB-9AEEDE23EB4A@holtmann.org> (raw)
In-Reply-To: <20231120215329.786768-1-gerickson@nuovations.com>
Hi Grant,
> There are a suffient number of instantiations of the following
> implementation pattern:
>
> set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
>
> to clear or reset the "Error" service property where it makes sense to
> embody this in a single function.
>
> This introduces and leverages the 'clear_error' function to embody
> this pattern.
>
> Grant Erickson (2):
> service: Add and leverage 'clear_error'.
> service: Document '{clear,set}_error'.
>
> src/service.c | 56 +++++++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 50 insertions(+), 6 deletions(-)
both patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-23 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 21:53 [PATCH 0/2] service: Add and Leverage 'clear_error' Grant Erickson
2023-11-20 21:53 ` [PATCH 1/2] service: Add and leverage 'clear_error' Grant Erickson
2023-11-20 21:53 ` [PATCH 2/2] service: Document '{clear,set}_error' Grant Erickson
2023-11-23 11:27 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F401339-13B4-47D2-9FDB-9AEEDE23EB4A@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).