From: Christophe Ronco <c.ronco@kerlink.fr>
To: connman@lists.linux.dev
Cc: Christophe Ronco <c.ronco@kerlink.fr>
Subject: [PATCH 0/1] End connection if connection failure and no agent
Date: Tue, 20 Feb 2024 11:11:38 +0100 [thread overview]
Message-ID: <20240220101139.36171-1-c.ronco@kerlink.fr> (raw)
I have a modem that is not able to reactivate a context just after a disconnection (I have an error in AT+CGDCONT in this case). Some seconds later, connection is possible.
With connman 1.39, here is what happens when I disconnect and reconnect corresponding connman service:
root@klk-zcel-030030:~ # date; connmanctl disconnect cellular_206018060790006_context1; date; connmanctl connect cellular_206018060790006_context1; date
Tue Feb 20 10:00:19 UTC 2024
Disconnected cellular_206018060790006_context1
Tue Feb 20 10:00:19 UTC 2024
Error /net/connman/service/cellular_206018060790006_context1: Input/output error
Tue Feb 20 10:00:20 UTC 2024
With connman 1.41, behavior changes:
root@klk-zcel-030030:/# date; connmanctl disconnect cellular_206018060790006_context1; date; connmanctl connect cellular_206018060790006_context1; date
Tue Jan 2 15:41:31 UTC 2024
Disconnected cellular_206018060790006_context1
Tue Jan 2 15:41:31 UTC 2024
Error /net/connman/service/cellular_206018060790006_context1: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
Tue Jan 2 15:43:31 UTC 2024
"connmanctl connect" lasts 2 minutes (it ends with connection timeout).
After the first unsuccessful connection attempt, nothing happens. No new context activation is asked to Ofono. During these 2 minutes, if I try to connect the service, I receive an "in progress" error. This looks like a bug to me.
Change comes from commit 8ea2d67a6e8935d06f71b1ec77a2f89d72be49eb (service: Complete only after user connection retries). service_complete is not called anymore when error is received from ofono plugin. We wait for agent to call report_error_cb. There is no agent in this case so report_error_cb is never called.
I think that service_complete should be called if there is no agent.
Christophe Ronco (1):
service: End connection if connection failure and no agent
src/service.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.25.1
next reply other threads:[~2024-02-20 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 10:11 Christophe Ronco [this message]
2024-02-20 10:11 ` [PATCH 1/1] service: End connection if connection failure and no agent Christophe Ronco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220101139.36171-1-c.ronco@kerlink.fr \
--to=c.ronco@kerlink.fr \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).