From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH] ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG.
Date: Wed, 20 Dec 2023 23:08:49 -0800 [thread overview]
Message-ID: <20231221070849.2354559-1-gerickson@nuovations.com> (raw)
With the "continuous" online check mode, logs can become dominated by
Linux Routing Netlink (rtnl) 'RTM_{ADD,DEL}ROUTE' entries every time
WISPr adds/deletes a host route for the online check.
This demotes those log invocations from 'connman_info' to 'DBG'.
---
src/ipconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 5ec619fa7e6b..c2d7d2bc02b8 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1102,7 +1102,7 @@ void __connman_ipconfig_newroute(int index, int family, unsigned char scope,
}
}
- connman_info("%s {add} route %s/%u gw %s scope %u <%s> table %u <%s> "
+ DBG("%s {add} route %s/%u gw %s scope %u <%s> table %u <%s> "
"metric %u",
ifname, dst, dst_prefixlen, gateway, scope, scope2str(scope),
table_id, __connman_inet_table2string(table_id), metric);
@@ -1174,7 +1174,7 @@ void __connman_ipconfig_delroute(int index, int family, unsigned char scope,
}
}
- connman_info("%s {del} route %s/%u gw %s scope %u <%s> table %u <%s> "
+ DBG("%s {del} route %s/%u gw %s scope %u <%s> table %u <%s> "
"metric %u",
ifname, dst, dst_prefixlen, gateway, scope, scope2str(scope),
table_id, __connman_inet_table2string(table_id), metric);
--
2.42.0
next reply other threads:[~2023-12-21 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 7:08 Grant Erickson [this message]
2023-12-23 12:21 ` [PATCH] ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221070849.2354559-1-gerickson@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).