From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH 0/2] service: Both Cancel and Stop Online Checks where Appropriate
Date: Thu, 14 Dec 2023 18:16:51 -0800 [thread overview]
Message-ID: <20231215021653.2156275-1-gerickson@nuovations.com> (raw)
This both cancels, via 'cancel_online_check', and stops, via
'__connman_wispr_stop' online checks on service disconnect or
free. The former terminates any in-flight or recurring check activity
in "service.c" and the latter terminates the same in "wispr.c".
Failure to cancel as well as stop can lead to a use-after-free fault
in one-shot or continuous online check mode when a latent online check
reschedule timer fires after the service has been disconnected or
deallocated.
To support these cancelations with a single 'cancel_online_check'
function call, support is added for passing
'CONNMAN_IPCONFIG_TYPE_ALL' to 'cancel_online_check' as the IP
configuration type parameter.
Grant Erickson (2):
service: Add support for 'CONNMAN_IPCONFIG_TYPE_ALL' to
'cancel_online_check'.
service: Both cancel and stop online checks where appropriate.
src/service.c | 43 +++++++++++++++++++++++++++++++++----------
1 file changed, 33 insertions(+), 10 deletions(-)
--
2.42.0
next reply other threads:[~2023-12-15 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 2:16 Grant Erickson [this message]
2023-12-15 2:16 ` [PATCH 1/2] service: Add support for 'CONNMAN_IPCONFIG_TYPE_ALL' to 'cancel_online_check' Grant Erickson
2023-12-15 2:16 ` [PATCH 2/2] service: Both cancel and stop online checks where appropriate Grant Erickson
2023-12-15 8:52 ` [PATCH 0/2] service: Both Cancel and Stop Online Checks where Appropriate Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215021653.2156275-1-gerickson@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).