ConnMan network manager
 help / color / mirror / Atom feed
From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH 0/2] service: Bifurcate 'complete_online_check' handling.
Date: Fri, 17 Nov 2023 16:22:42 -0800	[thread overview]
Message-ID: <20231118002244.723157-1-gerickson@nuovations.com> (raw)

This bifurcates 'complete_online_check' closure handling into a
success and failure handler: 'handle_online_check_success' and
'handle_online_check_failure'.
    
Both at present and as the continuous online check mode (also known
as, 'EnableOnlineToReadyTransition') evolves, the closure handling of
online checks is both more tractable and easier to reason about when
partitioned into success and failures rather than co-mingling both
into the same function. Moreover, this simplifies
'complete_online_check' itself.

Grant Erickson (2):
  service: Bifurcate 'complete_online_check' handling.
  service: Document 'handle_online_check_{failure,success}'.

 src/service.c | 199 ++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 168 insertions(+), 31 deletions(-)

-- 
2.42.0


             reply	other threads:[~2023-11-18  0:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  0:22 Grant Erickson [this message]
2023-11-18  0:22 ` [PATCH 1/2] service: Bifurcate 'complete_online_check' handling Grant Erickson
2023-11-18  0:22 ` [PATCH 2/2] service: Document 'handle_online_check_{failure,success}' Grant Erickson
2023-11-23 11:25 ` [PATCH 0/2] service: Bifurcate 'complete_online_check' handling Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231118002244.723157-1-gerickson@nuovations.com \
    --to=gerickson@nuovations.com \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).