From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH 58/58] service: Make DBG in '__connman_service_ipconfig_indicate_state' consistent.
Date: Fri, 17 Nov 2023 13:03:36 -0800 [thread overview]
Message-ID: <20231117210336.699149-1-gerickson@nuovations.com> (raw)
This makes the DBG statement in '__connman_service_ipconfig_indicate_state'
consistent in format of 'service <service_pointer> (<service_name>) type
<ipconfig_type> (<ipconfig_type_name>)' with that of other DBG statements
in the module.
This makes at-a-glance, columnar correlation and comparison of service
activities easier.
---
src/service.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/service.c b/src/service.c
index 81a1bebdc14b..a5aef1402933 100644
--- a/src/service.c
+++ b/src/service.c
@@ -7126,11 +7126,11 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
if (old_state == new_state)
return -EALREADY;
- DBG("service %p (%s) old state %d (%s) new state %d (%s) type %d (%s)",
+ DBG("service %p (%s) type %d (%s) old state %d (%s) new state %d (%s)",
service, connman_service_get_identifier(service),
+ type, __connman_ipconfig_type2string(type),
old_state, state2string(old_state),
- new_state, state2string(new_state),
- type, __connman_ipconfig_type2string(type));
+ new_state, state2string(new_state));
switch (new_state) {
case CONNMAN_SERVICE_STATE_UNKNOWN:
--
2.42.0
next reply other threads:[~2023-11-17 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 21:03 Grant Erickson [this message]
2023-11-17 21:05 ` [PATCH v2] service: Make DBG in '__connman_service_ipconfig_indicate_state' consistent Grant Erickson
2023-11-24 17:46 ` Grant Erickson
2023-11-25 16:31 ` Marcel Holtmann
2023-11-25 16:22 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117210336.699149-1-gerickson@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).