From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2] Be consistent about debug logging service and IP config type.
Date: Tue, 7 Nov 2023 16:36:09 +0100 [thread overview]
Message-ID: <16C43B08-AF56-4928-93EE-B8C8A61074F1@holtmann.org> (raw)
In-Reply-To: <1943BE4D-CEA9-4BA2-8815-F0F8D7BD2177@nuovations.com>
Hi Grant,
> In a number of DBG log instances, there are inconsistencies in what and
> how a service and its IP configuration type are logged. In some places,
> it is just pointers and enumeration values. In other places, it is
> pointers, identifiers, and strings without enumerated values.
>
> This makes several such instances consistent, logging the service
> pointer, the service instance name, the IP configuration type enumerated
> value and its string equivalent.
> ---
> src/proxy.c | 4 +++-
> src/service.c | 27 +++++++++++++++++++--------
> src/wispr.c | 14 +++++++++-----
> src/wpad.c | 2 +-
> 4 files changed, 32 insertions(+), 15 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 20:54 [PATCH] Be consistent about debug logging service and IP config type Grant Erickson
2023-11-01 23:22 ` [PATCH v2] " Grant Erickson
2023-11-07 15:36 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16C43B08-AF56-4928-93EE-B8C8A61074F1@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).