From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH] service: Enhance DBG in '__connman_service_indicate_default'.
Date: Fri, 3 Nov 2023 16:40:32 -0700 [thread overview]
Message-ID: <0B51F2F9-E96E-4C79-B757-EC697EE5CAF8@nuovations.com> (raw)
This enhances the DBG statement in '__connman_service_indicate_default'
by adding the service identifier. In addition, it aligns the content and
format with other DBG functions in the module to make debugging and at-
a-glance correlation easier, especially in a multi-technology environment
with "EnableOnlineToReadyTransition" asserted.
---
src/service.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/service.c b/src/service.c
index 75ed9ccd..ff6ee12f 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6746,7 +6746,9 @@ int __connman_service_clear_error(struct connman_service *service)
int __connman_service_indicate_default(struct connman_service *service)
{
- DBG("service %p state %s", service, state2string(service->state));
+ DBG("service %p (%s) state %d (%s)",
+ service, connman_service_get_identifier(service),
+ service->state, state2string(service->state));
if (!is_connected(service->state)) {
/*
--
2.42.0
next reply other threads:[~2023-11-03 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 23:40 Grant Erickson [this message]
2023-11-07 18:59 ` [PATCH] service: Enhance DBG in '__connman_service_indicate_default' Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0B51F2F9-E96E-4C79-B757-EC697EE5CAF8@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).