From: Julia Lawall <julia.lawall@inria.fr>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@inria.fr
Subject: Re: [cocci] [PATCH v2] coccinelle: device_attr_show: Remove useless expression STR
Date: Sun, 18 Feb 2024 09:17:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2402180917060.3095@hadrien> (raw)
In-Reply-To: <20240218080054.719008-1-lizhijian@fujitsu.com>
On Sun, 18 Feb 2024, Li Zhijian wrote:
> Commit ff82e84e80fc ("coccinelle: device_attr_show: simplify patch case")
> simplifies the patch case, as a result, STR is no longer needed.
>
> This also helps to fix below coccicheck warning:
> > warning: rp: metavariable STR not used in the - or context code
>
> CC: Julia Lawall <Julia.Lawall@inria.fr>
> CC: Nicolas Palix <nicolas.palix@imag.fr>
> CC: cocci@inria.fr
> Fixes: ff82e84e80fc ("coccinelle: device_attr_show: simplify patch case")
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Applied to my tree
> ---
> scripts/coccinelle/api/device_attr_show.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/api/device_attr_show.cocci b/scripts/coccinelle/api/device_attr_show.cocci
> index 550d1d2fc02a..dfcf9304195f 100644
> --- a/scripts/coccinelle/api/device_attr_show.cocci
> +++ b/scripts/coccinelle/api/device_attr_show.cocci
> @@ -28,7 +28,7 @@ ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
>
> @rp depends on patch@
> identifier show, dev, attr, buf;
> -expression BUF, SZ, FORMAT, STR;
> +expression BUF, SZ, FORMAT;
> @@
>
> ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
> --
> 2.29.2
>
>
parent reply other threads:[~2024-02-18 8:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240218080054.719008-1-lizhijian@fujitsu.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2402180917060.3095@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).