From: Julia Lawall <julia.lawall@inria.fr>
To: Deepak R Varma <drv@mailo.com>
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@inria.fr, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [cocci] [PATCH v2] coccinelle: api/atomic_as_refcounter: include message type in output
Date: Mon, 26 Dec 2022 21:51:55 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2212262151450.2933@hadrien> (raw)
In-Reply-To: <Y6mIQIubjvg7aX11@qemulion>
On Mon, 26 Dec 2022, Deepak R Varma wrote:
> A common practice is to grep for "WARNING" or "ERROR" text in the report
> output from a Coccinelle semantic patch script. So, include the text
> "WARNING: " in the report output generated by the semantic patch for
> desired filtering of the output. Also improves the readability of the
> output. Here is an example of the old and new outputs reported:
>
> xyz_file.c:131:39-40: atomic_add_unless
> xyz_file.c:131:39-40: WARNING: atomic_add_unless
>
> xyz_file.c:196:6-25: atomic_dec_and_test variation before object free at line 208.
> xyz_file.c:196:6-25: WARNING: atomic_dec_and_test variation before object free at line 208.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Applied, thanks.
> ---
>
> Changes in v2:
> 1. Correct word test to text in patch description. Feedback from Markus.Elfring@web.de
>
>
> scripts/coccinelle/api/atomic_as_refcounter.cocci | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci b/scripts/coccinelle/api/atomic_as_refcounter.cocci
> index e63d52408b86..bbe5b2932933 100644
> --- a/scripts/coccinelle/api/atomic_as_refcounter.cocci
> +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci
> @@ -55,7 +55,7 @@ identifier fname6 =~ ".*call_rcu.*";
> p1 << r1.p1;
> p2 << r1.p2;
> @@
> -msg = "atomic_dec_and_test variation before object free at line %s."
> +msg = "WARNING: atomic_dec_and_test variation before object free at line %s."
> coccilib.report.print_report(p1[0], msg % (p2[0].line))
>
> @r4 exists@
> @@ -88,7 +88,7 @@ fname@p2(y, ...);
> p1 << r4.p1;
> p2 << r4.p2;
> @@
> -msg = "atomic_dec_and_test variation before object free at line %s."
> +msg = "WARNING: atomic_dec_and_test variation before object free at line %s."
> coccilib.report.print_report(p1[0], msg % (p2[0].line))
>
> @r2 exists@
> @@ -107,7 +107,7 @@ atomic64_add_unless(&(a)->x,-1,1)@p1
> @script:python depends on report@
> p1 << r2.p1;
> @@
> -msg = "atomic_add_unless"
> +msg = "WARNING: atomic_add_unless"
> coccilib.report.print_report(p1[0], msg)
>
> @r3 exists@
> @@ -126,5 +126,5 @@ x = atomic64_add_return@p1(-1, ...);
> @script:python depends on report@
> p1 << r3.p1;
> @@
> -msg = "x = atomic_add_return(-1, ...)"
> +msg = "WARNING: x = atomic_add_return(-1, ...)"
> coccilib.report.print_report(p1[0], msg)
> --
> 2.34.1
>
>
>
>
prev parent reply other threads:[~2022-12-26 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 11:40 [cocci] [PATCH v2] coccinelle: api/atomic_as_refcounter: include message type in output Deepak R Varma
2022-12-26 20:51 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2212262151450.2933@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=drv@mailo.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).