From: Markus Elfring <Markus.Elfring@web.de>
To: Philipp Zabel <p.zabel@pengutronix.de>,
cocci@inria.fr, kernel-janitors@vger.kernel.org
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [cocci] [PATCH] coccinelle: api: explicitly request exclusive reset controls
Date: Thu, 7 Jul 2022 19:38:25 +0200 [thread overview]
Message-ID: <a4f59524-acdf-3431-e4d3-de9aa90655e9@web.de> (raw)
In-Reply-To: <20220707092030.3319988-1-p.zabel@pengutronix.de>
> scripts/coccinelle/api/reset-exclusive.cocci | 49 ++++++++++++++++++++
…
> +virtual patch
> +virtual report
How do you think about to support also the operation modes “context” and “org”?
> +@depends on patch@
> +expression x;
> +@@
> +
> + x =
> +(
> +-devm_reset_control_get
> ++devm_reset_control_get_exclusive
> +|
> +-devm_reset_control_get_optional
> ++devm_reset_control_get_optional_exclusive
> +|
> +-of_reset_control_get
> ++of_reset_control_get_exclusive
> +|
> +-of_reset_control_get_by_index
> ++of_reset_control_get_exclusive_by_index
> +|
> +-devm_reset_control_get_by_index
> ++devm_reset_control_get_exclusive_by_index
> +)
> + (...)
Did you order the case distinctions in the SmPL disjunction according to
the call frequencies of the mentioned function names?
> +@r depends on !patch exists@
> +expression x;
> +position p;
> +@@
> +
> +*x = \(devm_reset_control_get@p\|devm_reset_control_get_optional@p\|of_reset_control_get@p\|of_rset_control_get_by_index@p\|devm_reset_control_get_by_index@p\)(...)
I suggest to reconsider the influence of data processing according to
the SmPL asterisk functionality a bit more.
Regards,
Markus
prev parent reply other threads:[~2022-07-07 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 9:20 [cocci] [PATCH] coccinelle: api: explicitly request exclusive reset controls Philipp Zabel
2022-07-07 17:38 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4f59524-acdf-3431-e4d3-de9aa90655e9@web.de \
--to=markus.elfring@web.de \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).