From: Markus Elfring <Markus.Elfring@web.de>
To: kernel-janitors@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Dvorkin Dmitry <dvorkin@tibbo.com>,
Linus Walleij <linus.walleij@linaro.org>,
Wells Lu <wellslutw@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
cocci@inria.fr, Wells Lu <wells.lu@sunplus.com>
Subject: [cocci] [PATCH] pinctrl: sunplus: Delete an unnecessary check before kfree() in sppctl_dt_node_to_map()
Date: Tue, 6 Jun 2023 15:26:31 +0200 [thread overview]
Message-ID: <9ace5c4c-5e17-4207-5a02-6a47ba0aee22@web.de> (raw)
In-Reply-To: <1685277277-12209-1-git-send-email-wellslutw@gmail.com>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 6 Jun 2023 15:00:18 +0200
It can be known that the function “kfree” performs a null pointer check
for its input parameter.
It is therefore not needed to repeat such a check before its call.
Thus remove a redundant pointer check.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/sunplus/sppctl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sunplus/sppctl.c b/drivers/pinctrl/sunplus/sppctl.c
index e91ce5b5d559..150996949ede 100644
--- a/drivers/pinctrl/sunplus/sppctl.c
+++ b/drivers/pinctrl/sunplus/sppctl.c
@@ -971,8 +971,7 @@ static int sppctl_dt_node_to_map(struct pinctrl_dev *pctldev, struct device_node
sppctl_map_err:
for (i = 0; i < (*num_maps); i++)
- if (((*map)[i].type == PIN_MAP_TYPE_CONFIGS_PIN) &&
- (*map)[i].data.configs.configs)
+ if ((*map)[i].type == PIN_MAP_TYPE_CONFIGS_PIN)
kfree((*map)[i].data.configs.configs);
kfree(*map);
of_node_put(parent);
--
2.40.1
next parent reply other threads:[~2023-06-06 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1685277277-12209-1-git-send-email-wellslutw@gmail.com>
2023-06-06 13:26 ` Markus Elfring [this message]
[not found] ` <CACRpkdbe2AjD69tpgDDJKf0ge__hoTs72OuT9M-p21_q+z3f8w@mail.gmail.com>
2023-06-13 10:42 ` [cocci] pinctrl: sunplus: Delete an unnecessary check before kfree() in sppctl_dt_node_to_map() Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ace5c4c-5e17-4207-5a02-6a47ba0aee22@web.de \
--to=markus.elfring@web.de \
--cc=andy.shevchenko@gmail.com \
--cc=cocci@inria.fr \
--cc=dvorkin@tibbo.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wells.lu@sunplus.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).