From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Jakob Koschel <jkl820.git@gmail.com>, cocci@inria.fr
Subject: Re: [cocci] Working with parameter/expression lists by SmPL
Date: Sun, 21 Aug 2022 13:33:58 +0200 [thread overview]
Message-ID: <2c62caa7-56ad-b1dc-4045-84f008aff6be@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2208211200120.3263@hadrien>
>>> Could you repost your semantic patch and test code?
>>
>> I imagine that a semantic match (with the application of SmPL asterisks)
>> could be also helpful for the desired understanding of the discussed
>> transformation approach.
> I don't see why. I'm only concerned about why a // comment was added at
> the front of a line containing real code.
Jakob Koschel provided the following information yesterday.
https://sympa.inria.fr/sympa/arc/cocci/2022-08/msg00025.html
https://lore.kernel.org/cocci/5369B40D-9EA4-401F-A9CB-2CA1C0E3332E@gmail.com/
“…
I've only used adding the comment to see if the matching works correctly,
I'm not intending to do anything with comments in the final version.
…”
> Perhaps the pretty printer treats all comments the same...
How do you think about increasing case distinctions also for further improvements
of the Coccinelle software?
* Under which circumstances may comment additions influence the control flow?
* Should the addition of a C++-style comment (before an SmPL ellipsis)
eventually trigger the appending of a line break?
* Would you like to extend the test case collection accordingly?
Regards,
Markus
next prev parent reply other threads:[~2022-08-21 11:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 8:54 [cocci] match arbitrary argument position Jakob Koschel
2022-08-16 11:37 ` Julia Lawall
2022-08-16 12:35 ` Jakob Koschel
2022-08-16 17:55 ` Markus Elfring
2022-08-17 14:26 ` Jakob Koschel
2022-08-17 19:21 ` Markus Elfring
2022-08-16 21:07 ` Julia Lawall
2022-08-17 14:18 ` Jakob Koschel
2022-08-17 14:36 ` Julia Lawall
2022-08-17 14:50 ` Jakob Koschel
2022-08-17 15:26 ` Julia Lawall
2022-08-17 19:48 ` [cocci] Working with parameter/expression lists by SmPL Markus Elfring
2022-08-18 12:51 ` Jakob Koschel
2022-08-18 17:42 ` Markus Elfring
2022-08-19 9:12 ` Jakob Koschel
2022-08-19 9:57 ` Julia Lawall
2022-08-19 10:00 ` Jakob Koschel
2022-08-19 17:00 ` Markus Elfring
2022-08-20 12:57 ` Jakob Koschel
2022-08-21 8:10 ` Markus Elfring
2022-08-21 9:09 ` Julia Lawall
2022-08-21 9:46 ` Markus Elfring
2022-08-21 10:01 ` Julia Lawall
2022-08-21 11:33 ` Markus Elfring [this message]
2022-08-18 18:00 ` [cocci] Checking a comment addition Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c62caa7-56ad-b1dc-4045-84f008aff6be@web.de \
--to=markus.elfring@web.de \
--cc=cocci@inria.fr \
--cc=jkl820.git@gmail.com \
--cc=julia.lawall@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).