From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: cocci@inria.fr
Subject: [cocci] Spatch 1.1.1 backward incompatibility
Date: Fri, 16 Feb 2024 10:24:23 +0100 [thread overview]
Message-ID: <162c5e8c-54c2-4b86-9735-887b8ba26f89@linbit.com> (raw)
Hi,
I recently(?) got a new version of coccinelle from Fedora:
$ spatch --version
spatch version 1.1.1 compiled with OCaml version 5.0.1+dev0-2022-12-15
Flags passed to the configure script: --build=x86_64-redhat-linux-gnu
--host=x86_64-redhat-linux-gnu --program-prefix=
--disable-dependency-tracking --prefix=/usr --exec-prefix=/usr
--bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
--datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64
--libexecdir=/usr/libexec --localstatedir=/var --runstatedir=/run
--sharedstatedir=/var/lib --mandir=/usr/share/man
--infodir=/usr/share/info --with-python=/usr/bin/python3
--with-menhir=/usr/bin/menhir
OCaml scripting support: yes
Python scripting support: yes
Syntax of regular expressions: PCRE
And it broke a lot of our semantic patches. I now get lots of these
warnings:
warning: rule starting on line 248, node 45:
kunmap_local(...)[1,2,20,21,25] in recv_dless_read may be inconsistently
modified
warning: rule starting on line 248, node 42: decl:mapped[1,2,20,21,22]
in recv_dless_read may be inconsistently modified
warning: rule starting on line 273, node 18: src = ... ;[1,2,8,9,11] in
drbd_csum_bio may be inconsistently modified
warning: rule starting on line 273, node 20:
kunmap_local(...)[1,2,8,9,13] in drbd_csum_bio may be inconsistently
modified
(By the way: these are reported on stdout, I'm not sure that's intended
either)
And the patch output is noticeably different.
This all works fine on 1.1.0, and curiously it also works on the 1.1.1
version in Ubuntu:
$ spatch --version
spatch version 1.1.1 compiled with OCaml version 4.13.1
Flags passed to the configure script: --prefix=/usr --sysconfdir=/etc
--libdir=/usr/lib --enable-ocaml --enable-python --enable-opt
OCaml scripting support: yes
Python scripting support: yes
Syntax of regular expressions: PCRE
I'm trying to come up with a minimal reproducer right now, but just
throwing this out there in case anyone has an idea.
Thanks!
--
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA — Disaster Recovery — Software defined Storage
next reply other threads:[~2024-02-16 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:24 Christoph Böhmwalder [this message]
2024-02-16 9:51 ` [cocci] Spatch 1.1.1 backward incompatibility Julia Lawall
2024-02-16 12:20 ` Christoph Böhmwalder
2024-02-16 12:47 ` Markus Elfring
2024-02-16 13:05 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162c5e8c-54c2-4b86-9735-887b8ba26f89@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=cocci@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).