From: Markus Elfring <Markus.Elfring@web.de>
To: Lu Hongfei <luhongfei@vivo.com>,
kernel-janitors@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, opensource.kernel@vivo.com,
Angelo Gioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Moudy Ho <moudy.ho@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Sun Ke <sunke32@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: [cocci] [PATCH] media: platform: mtk-mdp3: Fix resource leaks in mdp_comp_config()?
Date: Mon, 12 Jun 2023 19:06:32 +0200 [thread overview]
Message-ID: <0b0058e2-22f7-a32c-5c19-236d31391480@web.de> (raw)
In-Reply-To: <20230530094541.23396-1-luhongfei@vivo.com>
I would find an other patch subject more appropriate.
> for_each_child_of_node should have of_node_put() avoid resource leaks.
Please replace this sentence by an imperative change suggestion.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc6#n94
Regards,
Markus
parent reply other threads:[~2023-06-12 17:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230530094541.23396-1-luhongfei@vivo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b0058e2-22f7-a32c-5c19-236d31391480@web.de \
--to=markus.elfring@web.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=cocci@inria.fr \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luhongfei@vivo.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=opensource.kernel@vivo.com \
--cc=ping-hsun.wu@mediatek.com \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).