From: Dave Chinner <david@fromorbit.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v5 6/8] xfs: switch to multigrain timestamps
Date: Wed, 19 Jul 2023 11:35:37 +1000 [thread overview]
Message-ID: <ZLc96V2Yo72sthsi@dread.disaster.area> (raw)
In-Reply-To: <20230713-mgctime-v5-6-9eb795d2ae37@kernel.org>
On Thu, Jul 13, 2023 at 07:00:55PM -0400, Jeff Layton wrote:
> Enable multigrain timestamps, which should ensure that there is an
> apparent change to the timestamp whenever it has been written after
> being actively observed via getattr.
>
> Also, anytime the mtime changes, the ctime must also change, and those
> are now the only two options for xfs_trans_ichgtime. Have that function
> unconditionally bump the ctime, and warn if XFS_ICHGTIME_CHG is ever not
> set.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/xfs/libxfs/xfs_trans_inode.c | 6 +++---
> fs/xfs/xfs_iops.c | 4 ++--
> fs/xfs/xfs_super.c | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c
> index 0c9df8df6d4a..86f5ffce2d89 100644
> --- a/fs/xfs/libxfs/xfs_trans_inode.c
> +++ b/fs/xfs/libxfs/xfs_trans_inode.c
> @@ -62,12 +62,12 @@ xfs_trans_ichgtime(
> ASSERT(tp);
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
>
> - tv = current_time(inode);
> + /* If the mtime changes, then ctime must also change */
> + WARN_ON_ONCE(!(flags & XFS_ICHGTIME_CHG));
Make that an ASSERT(flags & XFS_ICHGTIME_CHG), please. There's no
need to verify this at runtime on production kernels.
-Dave.
--
Dave Chinner
david at fromorbit.com
next prev parent reply other threads:[~2023-07-19 1:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 23:00 [Cluster-devel] [PATCH v5 0/8] fs: implement multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 1/8] fs: pass the request_mask to generic_fillattr Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 2/8] fs: add infrastructure for multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 3/8] tmpfs: bump the mtime/ctime/iversion when page becomes writeable Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 4/8] tmpfs: add support for multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 5/8] xfs: XFS_ICHGTIME_CREATE is unused Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 6/8] xfs: switch to multigrain timestamps Jeff Layton
2023-07-19 1:35 ` Dave Chinner [this message]
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 7/8] ext4: " Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 8/8] btrfs: convert " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLc96V2Yo72sthsi@dread.disaster.area \
--to=david@fromorbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).