From: Deepak R Varma <drv@mailo.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Replace deprecated kmap_atomic() by kmap_local_page()
Date: Tue, 27 Jun 2023 23:55:57 +0530 [thread overview]
Message-ID: <ZJsptSAVHroP5hDk@bu2204.myguest.virtualbox.org> (raw)
In-Reply-To: <1905283.taCxCBeP46@suse>
On Tue, Jun 27, 2023 at 01:11:46PM +0200, Fabio M. De Francesco wrote:
> On domenica 25 giugno 2023 21:23:21 CEST Deepak R Varma wrote:
> > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}().
> >
> > }
> > - p = kmap_atomic(page);
> > + p = kmap_local_page(page);
> > amt = size - copied;
> > if (offset + size > PAGE_SIZE)
> > amt = PAGE_SIZE - offset;
> > memcpy(buf + copied, p + offset, amt);
>
> How about using memcpy_from_page()?
We can do that. I will include that in v3.
Deepak.
>
> Fabio
>
> > - kunmap_atomic(p);
> > + kunmap_local(p);
> > put_page(page);
> > copied += amt;
> > index++;
> > --
> > 2.34.1
>
>
>
>
prev parent reply other threads:[~2023-06-27 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZJiUKeVy7G6ZkX80@bu2204.myguest.virtualbox.org>
2023-06-27 11:11 ` [Cluster-devel] [PATCH] gfs2: Replace deprecated kmap_atomic() by kmap_local_page() Fabio M. De Francesco
2023-06-27 18:25 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJsptSAVHroP5hDk@bu2204.myguest.virtualbox.org \
--to=drv@mailo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).