From: Song Liu <song@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails
Date: Mon, 10 Apr 2023 09:06:06 -0700 [thread overview]
Message-ID: <CAPhsuW4yQjNgHZpw4UzkhC+GkY+aAFSjC-PDQFFoL-Wg-u2r1Q@mail.gmail.com> (raw)
In-Reply-To: <bbc98aa3-24f0-8ee6-9d74-483564a14f0f@kernel.org>
On Tue, Apr 4, 2023 at 1:26?AM Johannes Thumshirn <jth@kernel.org> wrote:
>
> On 31/03/2023 20:13, Song Liu wrote:
> > On Thu, Mar 30, 2023 at 3:44?AM Johannes Thumshirn
> > <johannes.thumshirn@wdc.com> wrote:
> >>
> >> Check if adding pages to resync bio fails and if bail out.
> >>
> >> As the comment above suggests this cannot happen, WARN if it actually
> >> happens.
> >>
> >> This way we can mark bio_add_pages as __must_check.
> >>
> >> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> >> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> >> ---
> >> drivers/md/raid1-10.c | 7 ++++++-
> >> drivers/md/raid10.c | 12 ++++++++++--
> >> 2 files changed, 16 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c
> >> index e61f6cad4e08..c21b6c168751 100644
> >> --- a/drivers/md/raid1-10.c
> >> +++ b/drivers/md/raid1-10.c
> >> @@ -105,7 +105,12 @@ static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp,
> >> * won't fail because the vec table is big
> >> * enough to hold all these pages
> >> */
> >
> > We know these won't fail. Shall we just use __bio_add_page?
>
> We could yes, but I kind of like the assert() style warning.
> But of cause ultimately your call.
The assert() style warning is fine. In this case, please remove the
"won't fail ..." comments.
Thanks,
Song
next prev parent reply other threads:[~2023-04-10 16:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 10:43 [Cluster-devel] [PATCH v2 00/19] bio: check return values of bio_add_page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 01/19] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 02/19] drbd: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 03/19] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 04/19] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 05/19] md: use __bio_add_page to add single page Johannes Thumshirn
2023-03-31 17:47 ` Song Liu
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 06/19] md: raid5-log: " Johannes Thumshirn
2023-03-31 17:47 ` Song Liu
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 07/19] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-03-31 17:47 ` Song Liu
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 08/19] btrfs: repair: use __bio_add_page for adding single page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 09/19] btrfs: raid56: use __bio_add_page to add " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 10/19] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-03-30 16:50 ` Dave Kleikamp
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 11/19] gfs: use __bio_add_page for adding " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 12/19] zonefs: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 13/19] zram: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 14/19] floppy: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 15/19] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-03-31 17:54 ` Song Liu
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 16/19] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-03-31 17:59 ` Song Liu
2023-03-30 10:43 ` [Cluster-devel] [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-03-31 18:13 ` Song Liu
2023-04-04 8:26 ` Johannes Thumshirn
2023-04-10 16:06 ` Song Liu [this message]
2023-03-30 10:44 ` [Cluster-devel] [PATCH v2 18/19] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-03-30 10:44 ` [Cluster-devel] [PATCH v2 19/19] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-03-30 15:45 ` [Cluster-devel] [PATCH v2 00/19] bio: check return values of bio_add_page David Sterba
2023-03-30 16:41 ` Johannes Thumshirn
2023-03-30 19:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW4yQjNgHZpw4UzkhC+GkY+aAFSjC-PDQFFoL-Wg-u2r1Q@mail.gmail.com \
--to=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).