From: Alexander Aring <aahringo@redhat.com>
To: teigland@redhat.com
Cc: cluster-devel@redhat.com, bmarson@redhat.com, stable@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH dlm/next] dlm: fix plock lookup when using multiple lockspaces
Date: Fri, 25 Aug 2023 09:28:01 -0400 [thread overview]
Message-ID: <CAK-6q+j=i176L=sC-xAXC6+rSrUhuSeTxWMrpwExeHTpDGKrGw@mail.gmail.com> (raw)
In-Reply-To: <CAK-6q+iUe1=68LFv=BVd4MxVhtPf=jGPRFfXXNopEB2J+gjWqg@mail.gmail.com>
Hi,
On Thu, Aug 24, 2023 at 7:22 PM Alexander Aring <aahringo@redhat.com> wrote:
...
>
> The reason why I probably never saw it is because those fields in my
> tests are always the same and we simply don't compare all fields on
> the sanity check.
I need to correct some things here... the patch works, but the commit
message related to some locking issues is wrong. It works to make the
lookup on a per lockspace basis because dlm_controld has a per
lockspace corosync handle. Corosync keeps plock_op and results in
order which is necessary for the lookup mechanism here. So this
mechanism is on a per lockspace basis in order, if dlm_controld would
have a global corosync handle it would work on a global basis.
The issue I saw with putting more sanity checks for start/end fields
does not work because DLM_PLOCK_OP_GET will manipulate fields and they
can't be compared between original request and result. I ran into this
issue a couple times...
- Alex
prev parent reply other threads:[~2023-08-25 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 20:51 [Cluster-devel] [PATCH dlm/next] dlm: fix plock lookup when using multiple lockspaces Alexander Aring
2023-08-24 23:22 ` Alexander Aring
2023-08-25 13:28 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK-6q+j=i176L=sC-xAXC6+rSrUhuSeTxWMrpwExeHTpDGKrGw@mail.gmail.com' \
--to=aahringo@redhat.com \
--cc=bmarson@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=stable@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).