From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 7/9] gfs2: update ctime when quota is updated
Date: Wed, 5 Jul 2023 22:25:51 +0200 [thread overview]
Message-ID: <CAHc6FU54Gh+5hovqXZZSADqym=VCMis-EH9sKhAjgjXD6MUtqw@mail.gmail.com> (raw)
In-Reply-To: <a1f7a725186082d933aff702d1d50c6456da6f20.camel@kernel.org>
On Mon, Jun 12, 2023 at 12:36?PM Jeff Layton <jlayton@kernel.org> wrote:
> On Fri, 2023-06-09 at 18:44 +0200, Andreas Gruenbacher wrote:
> > Jeff,
> >
> > On Fri, Jun 9, 2023 at 2:50?PM Jeff Layton <jlayton@kernel.org> wrote:
> > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > > ---
> > > fs/gfs2/quota.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
> > > index 1ed17226d9ed..6d283e071b90 100644
> > > --- a/fs/gfs2/quota.c
> > > +++ b/fs/gfs2/quota.c
> > > @@ -869,7 +869,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc,
> > > size = loc + sizeof(struct gfs2_quota);
> > > if (size > inode->i_size)
> > > i_size_write(inode, size);
> > > - inode->i_mtime = inode->i_atime = current_time(inode);
> > > + inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode);
> >
> > I don't think we need to worry about the ctime of the quota inode as
> > that inode is internal to the filesystem only.
> >
>
> Thanks Andreas. I'll plan to drop this patch from the series for now.
>
> Does updating the mtime and atime here serve any purpose, or should
> those also be removed? If you plan to keep the a/mtime updates then I'd
> still suggest updating the ctime for consistency's sake. It shouldn't
> cost anything extra to do so since you're dirtying the inode below
> anyway.
Yes, good point actually, we should keep things consistent for simplicity.
Would you add this back in if you do another posting?
Thanks,
Andreas
> Thanks!
>
> > > mark_inode_dirty(inode);
> > > set_bit(QDF_REFRESH, &qd->qd_flags);
> > > }
> > > --
> > > 2.40.1
> > >
> >
> > Thanks,
> > Andreas
> >
>
> --
> Jeff Layton <jlayton@kernel.org>
>
next prev parent reply other threads:[~2023-07-05 20:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 12:50 [Cluster-devel] [PATCH 0/9] fs: add some missing ctime updates Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 1/9] ibmvmc: update ctime in conjunction with mtime on write Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 2/9] usb: update the ctime as well when updating mtime after an ioctl Jeff Layton
2023-06-09 13:10 ` Greg Kroah-Hartman
2023-06-09 12:50 ` [Cluster-devel] [PATCH 3/9] autofs: set ctime as well when mtime changes on a dir Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 4/9] bfs: update ctime in addition to mtime when adding entries Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 5/9] efivarfs: update ctime when mtime changes on a write Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 6/9] exfat: ensure that ctime is updated whenever the mtime is Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 7/9] gfs2: update ctime when quota is updated Jeff Layton
2023-06-09 16:44 ` Andreas Gruenbacher
2023-06-12 10:36 ` Jeff Layton
2023-07-05 20:25 ` Andreas Gruenbacher [this message]
2023-07-05 21:48 ` Jeff Layton
2023-07-05 23:19 ` Andreas Grünbacher
2023-06-09 12:50 ` [Cluster-devel] [PATCH 8/9] apparmor: update ctime whenever the mtime changes on an inode Jeff Layton
2023-06-09 12:50 ` [Cluster-devel] [PATCH 9/9] cifs: update the ctime on a partial page write Jeff Layton
2023-06-09 13:10 ` [Cluster-devel] [PATCH 0/9] fs: add some missing ctime updates Greg Kroah-Hartman
2023-06-09 13:27 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHc6FU54Gh+5hovqXZZSADqym=VCMis-EH9sKhAjgjXD6MUtqw@mail.gmail.com' \
--to=agruenba@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).