From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Move a variable assignment behind a null pointer check in inode_go_dump()
Date: Tue, 18 Apr 2023 14:51:05 +0200 [thread overview]
Message-ID: <CAHc6FU4RekTwC9jH-H898PCyufrE59NYqZWy_V3p7R7dOCaTDA@mail.gmail.com> (raw)
In-Reply-To: <5800e1f5-8681-e140-fef0-8b2c3b4b6efa@web.de>
Hi Markus,
On Thu, Apr 13, 2023 at 9:23?PM Markus Elfring <Markus.Elfring@web.de> wrote:
> Date: Thu, 13 Apr 2023 20:54:30 +0200
>
> The address of a data structure member was determined before
> a corresponding null pointer check in the implementation of
> the function ?inode_go_dump?.
>
> Thus avoid the risk for undefined behaviour by moving the assignment
> for the variable ?inode? behind the null pointer check.
>
> This issue was detected by using the Coccinelle software.
>
> Fixes: 27a2660f1ef944724956d92e8a312b6da0936fae ("gfs2: Dump nrpages for inodes and their glocks")
Okay, that's a worthwhile cleanup. It doesn't actually fix a bug, so
I'm not going to add a Fixes tag, though.
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> fs/gfs2/glops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
> index b65950e76be5..6e33c8058059 100644
> --- a/fs/gfs2/glops.c
> +++ b/fs/gfs2/glops.c
> @@ -535,12 +535,13 @@ static void inode_go_dump(struct seq_file *seq, struct gfs2_glock *gl,
> const char *fs_id_buf)
> {
> struct gfs2_inode *ip = gl->gl_object;
> - struct inode *inode = &ip->i_inode;
> + struct inode *inode;
> unsigned long nrpages;
>
> if (ip == NULL)
> return;
>
> + inode = &ip->i_inode;
> xa_lock_irq(&inode->i_data.i_pages);
> nrpages = inode->i_data.nrpages;
> xa_unlock_irq(&inode->i_data.i_pages);
> --
> 2.40.0
>
Thanks,
Andreas
prev parent reply other threads:[~2023-04-18 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <40c60719-4bfe-b1a4-ead7-724b84637f55@web.de>
[not found] ` <1a11455f-ab57-dce0-1677-6beb8492a257@web.de>
2023-04-13 19:10 ` [Cluster-devel] [PATCH] gfs2: Move a variable assignment behind a null pointer check in inode_go_dump() Markus Elfring
2023-04-18 12:51 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU4RekTwC9jH-H898PCyufrE59NYqZWy_V3p7R7dOCaTDA@mail.gmail.com \
--to=agruenba@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).