From: Pankaj Raghav <p.raghav@samsung.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 13/19] zram: use __bio_add_page for adding single page to bio
Date: Fri, 31 Mar 2023 14:20:11 +0200 [thread overview]
Message-ID: <20230331122011.nq27xmkqmajvx6a5@blixen> (raw)
In-Reply-To: <339841b3b7ce6b2faf56bcaf9d92e298d878ef64.1680108414.git.johannes.thumshirn@wdc.com>
On Wed, Mar 29, 2023 at 10:05:59AM -0700, Johannes Thumshirn wrote:
> The zram writeback code uses bio_add_page() to add a page to a newly
> created bio. bio_add_page() can fail, but the return value is never
> checked.
>
> Use __bio_add_page() as adding a single page to a newly created bio is
> guaranteed to succeed.
>
> This brings us a step closer to marking bio_add_page() as __must_check.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Looks good,
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>
next prev parent reply other threads:[~2023-03-31 12:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 17:05 [Cluster-devel] [PATCH 00/19] bio: check return values of bio_add_page Johannes Thumshirn
2023-03-29 17:05 ` [Cluster-devel] [PATCH 01/19] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-03-29 23:29 ` Damien Le Moal
[not found] ` <CGME20230331122046eucas1p247e0cd2d06229a6b7cae9cb26ea43d5b@eucas1p2.samsung.com>
2023-03-31 12:12 ` Pankaj Raghav
2023-03-29 17:05 ` [Cluster-devel] [PATCH 02/19] drbd: " Johannes Thumshirn
2023-03-29 17:48 ` Matthew Wilcox
2023-03-29 23:29 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 03/19] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-03-29 23:30 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 04/19] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-03-29 23:31 ` Damien Le Moal
[not found] ` <CGME20230331122235eucas1p2208286ce210d9b01ea36a26bd3897b72@eucas1p2.samsung.com>
2023-03-31 12:14 ` Pankaj Raghav
2023-03-29 17:05 ` [Cluster-devel] [PATCH 05/19] md: use __bio_add_page to add single page Johannes Thumshirn
2023-03-29 23:31 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 06/19] md: raid5-log: " Johannes Thumshirn
2023-03-29 23:32 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 07/19] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-03-29 23:32 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 08/19] btrfs: repair: use __bio_add_page for adding single page Johannes Thumshirn
2023-03-29 23:33 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 09/19] btrfs: raid56: use __bio_add_page to add " Johannes Thumshirn
2023-03-29 23:33 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 10/19] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-03-29 23:34 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 11/19] gfs: use __bio_add_page for adding " Johannes Thumshirn
2023-03-29 23:34 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 12/19] zonefs: " Johannes Thumshirn
2023-03-29 23:35 ` Damien Le Moal
2023-03-29 17:05 ` [Cluster-devel] [PATCH 13/19] zram: " Johannes Thumshirn
2023-03-29 23:36 ` Damien Le Moal
[not found] ` <CGME20230331122828eucas1p18e0bbbda45a6955f59fc82b29f42a8bb@eucas1p1.samsung.com>
2023-03-31 12:20 ` Pankaj Raghav [this message]
2023-03-29 17:06 ` [Cluster-devel] [PATCH 14/19] floppy: " Johannes Thumshirn
2023-03-29 23:36 ` Damien Le Moal
2023-03-29 17:06 ` [Cluster-devel] [PATCH 15/19] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-03-29 23:38 ` Damien Le Moal
2023-03-29 17:06 ` [Cluster-devel] [PATCH 16/19] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-03-29 23:38 ` Damien Le Moal
2023-03-29 17:06 ` [Cluster-devel] [PATCH 17/19] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-03-29 23:44 ` Damien Le Moal
2023-03-30 10:38 ` Johannes Thumshirn
2023-03-29 17:06 ` [Cluster-devel] [PATCH 18/19] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-03-29 23:49 ` Damien Le Moal
2023-03-30 0:17 ` Yang Shi
2023-03-30 0:24 ` Damien Le Moal
2023-03-30 22:29 ` Yang Shi
2023-03-29 17:06 ` [Cluster-devel] [PATCH 19/19] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-03-29 23:58 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331122011.nq27xmkqmajvx6a5@blixen \
--to=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).