From: Kees Cook <keescook@chromium.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: Replace all non-returning strlcpy with strscpy
Date: Mon, 22 May 2023 12:39:34 -0700 [thread overview]
Message-ID: <168478437619.244538.1491421946258356417.b4-ty@chromium.org> (raw)
In-Reply-To: <20230510221237.3509484-1-azeemshaikh38@gmail.com>
On Wed, 10 May 2023 22:12:37 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] dlm: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/30ad0627f169
--
Kees Cook
prev parent reply other threads:[~2023-05-22 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 22:12 [Cluster-devel] [PATCH] dlm: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-11 16:26 ` Kees Cook
2023-05-22 16:18 ` Azeem Shaikh
2023-05-22 19:39 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168478437619.244538.1491421946258356417.b4-ty@chromium.org \
--to=keescook@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).