From: Gylstorff Quirin <quirin.gylstorff@siemens.com>
To: cip-dev@lists.cip-project.org,
Rakesh Kumar <kumar.rakesh@siemens.com>,
"Kiszka, Jan (CT RDA IOT SES-DE)" <jan.kiszka@siemens.com>
Subject: Re: [cip-dev] [isar-cip-core][PATCH v1 1/1] recipes-devtools/secure-boot-secrets: Resolve duplicate Provides in debian/control
Date: Fri, 19 Apr 2024 09:30:25 +0200 [thread overview]
Message-ID: <56321bd1-6188-4d31-b740-c7e488e1a1d2@siemens.com> (raw)
In-Reply-To: <5b0ae665-7634-4288-9986-18b1df5cb38c@siemens.com>
On 4/19/24 9:22 AM, Quirin Gylstorff via lists.cip-project.org wrote:
>
>
> On 4/18/24 10:27 PM, Jan Kiszka via lists.cip-project.org wrote:
>> On 18.04.24 13:03, Rakesh Kumar wrote:
>>> Previously, the debian/control file contained a duplicate Provides line,
>>> which caused a build failure ad below
>>> | DEBUG: Executing shell function do_dpkg_source
>>> | dpkg-source: error: syntax error in
>>> secure-boot-custmpk-0.1/debian/control at line 16:
>>> | duplicate field Provides found
>>>
>>> Use DEBIAN_PROVIDES to resolve the duplicate Provides problem to ensure
>>> that the build process completes successfully.
>>>
>>> Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
>>> ---
>>> recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git
>>> a/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
>>> b/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
>>> index 76233b3..559d295 100644
>>> --- a/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
>>> +++ b/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
>>> @@ -12,6 +12,7 @@
>>> inherit dpkg-raw
>>> PROVIDES += "secure-boot-secrets"
>>> +DEBIAN_PROVIDES = "${PROVIDES}"
>>> SB_KEY ??= ""
>>> SB_CERT ??= ""
>>> @@ -29,6 +30,3 @@ do_install() {
>>> install -m 0700 ${WORKDIR}/${SB_CERT} ${TARGET}/secure-boot.pem
>>> }
>>> -do_prepare_build:append() {
>>> - echo "Provides: secure-boot-secrets" >> ${S}/debian/control
>>> -}
>>
>> Thanks for finding this. Can expand your patch to cover the other two
>> cases we have in-tree as well?
>
> This has no impact without updating ISAR first. NACK until then.
We are using 0.10. DEBIAN PROVIDES is introduced with
4d0955547453e4303f1f274354a0fb6558a74fa9 after 0.10
> Quirin
>>
>> Jan
>>
>>
>>
>>
>>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15584): https://lists.cip-project.org/g/cip-dev/message/15584
> Mute This Topic: https://lists.cip-project.org/mt/105596040/1753640
> Group Owner: cip-dev+owner@lists.cip-project.org
> Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129121/1753640/1405269326/xyzzy [quirin.gylstorff@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2024-04-19 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 11:03 [isar-cip-core][PATCH v1 1/1] recipes-devtools/secure-boot-secrets: Resolve duplicate Provides in debian/control Rakesh Kumar
2024-04-18 20:27 ` Jan Kiszka
2024-04-19 7:22 ` [cip-dev] " Gylstorff Quirin
2024-04-19 7:30 ` Gylstorff Quirin [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-18 10:15 [isar-cip-core][PATCH v1 0/1] " Rakesh Kumar
2024-04-18 10:15 ` [isar-cip-core][PATCH v1 1/1] " Rakesh Kumar
2024-04-19 5:32 ` [cip-dev] " Arjunan, Srinu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56321bd1-6188-4d31-b740-c7e488e1a1d2@siemens.com \
--to=quirin.gylstorff@siemens.com \
--cc=cip-dev@lists.cip-project.org \
--cc=jan.kiszka@siemens.com \
--cc=kumar.rakesh@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).