From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org,
Lalith Rajendran <lalithkraj@chromium.org>,
chrome-platform@lists.linux.dev,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v1] chrome/cros_ec: Handle events during suspend after resume completion
Date: Fri, 26 Apr 2024 12:37:24 +0800 [thread overview]
Message-ID: <ZisvhAg5Jy_IE-AV@google.com> (raw)
In-Reply-To: <20240425143710.v1.1.If2e0cef959f1f6df9f4d1ab53a97c54aa54208af@changeid>
On Thu, Apr 25, 2024 at 02:37:11PM -0600, Karthikeyan Ramasubramanian wrote:
> On boards where EC IRQ is not wake capable, EC does not trigger IRQ to
> signal any non-wake events until EC receives host resume event.
The sentence looks irrelevant to the fix. Presumably, EC should send those
pending non-wake events after it receives host resume event.
> Commit 47ea0ddb1f56 ("platform/chrome: cros_ec_lpc: Separate host
> command and irq disable") separated enabling IRQ and sending resume
> event host command into early_resume and resume_complete stages
> respectively. This separation leads to host not handling certain events
> posted during a small time window between early_resume and
> resume_complete stages. This change moves handling all events that
> happened during suspend after sending host resume event.
The regression you see is probably not due to the "separation" but an unwanted
code reorder.
Before 47ea0ddb1f56[1], a resume is:
1) Enable IRQ.
2) Send resume event.
3) Handle pending events.
After 47ea0ddb1f56[2], a resume is:
1) Enable IRQ.
2) Handle pending events.
3) Send resume event.
If there are some more events pending between 2) and 3), they would be handled
further late.
[1]: https://elixir.bootlin.com/linux/v6.6/source/drivers/platform/chrome/cros_ec.c#L381
[2]: https://elixir.bootlin.com/linux/v6.7/source/drivers/platform/chrome/cros_ec.c#L438
I see what the patch tries to fix but the commit message makes less sense to
me. Please fix accordingly.
prev parent reply other threads:[~2024-04-26 4:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 20:37 [PATCH v1] chrome/cros_ec: Handle events during suspend after resume completion Karthikeyan Ramasubramanian
2024-04-26 4:37 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZisvhAg5Jy_IE-AV@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=kramasub@chromium.org \
--cc=lalithkraj@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).