From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ting Shen <phoenixshen@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
fshao@chromium.org, "Ting Shen" <phoenixshen@google.com>,
"Benson Leung" <bleung@chromium.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
chrome-platform@lists.linux.dev, "joewu (吳仲振)" <joewu@msi.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: cros_ec_keyb: add support for base attached event
Date: Fri, 19 Jan 2024 00:15:11 -0800 [thread overview]
Message-ID: <Zaovj86pZIZdDQiJ@google.com> (raw)
In-Reply-To: <20240119074831.2979671-1-phoenixshen@google.com>
On Fri, Jan 19, 2024 at 03:48:17PM +0800, Ting Shen wrote:
> There is a new type of ChromeOS detachable keyboard that talks to
> the host via CrOS EC host command interface, rather than the USB
> interface.
>
> To trigger the firmware update daemon (hammerd) on this keyboard, a
> signal is required to replace the typical USB hotplug event. This patch
> addresses this by mapping the EC's BASE_ATTACHED event to SW_DOCK.
I think emitting an uevent on attachment might make more sense here,
SW_DOCK is to signal attachment of a legacy docking station.
Thanks.
--
Dmitry
prev parent reply other threads:[~2024-01-19 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 7:48 [PATCH v2] Input: cros_ec_keyb: add support for base attached event Ting Shen
2024-01-19 8:15 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zaovj86pZIZdDQiJ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=fshao@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=joewu@msi.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenixshen@chromium.org \
--cc=phoenixshen@google.com \
--cc=tzungbi@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).