From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Lalith Rajendran <lalithkraj@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Raul E Rangel <rrangel@chromium.org>,
Tim Van Patten <timvp@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3] platform/chrome: cros_ec_lpc: Separate host command and irq disable
Date: Wed, 25 Oct 2023 08:23:45 +0800 [thread overview]
Message-ID: <ZThgEdJuxTmucKIe@google.com> (raw)
In-Reply-To: <20231024105820.v3.1.Icccaed152371dbab868295a6c83d257e8409cf2d@changeid>
On Tue, Oct 24, 2023 at 10:58:21AM -0500, Lalith Rajendran wrote:
> +/**
> + * cros_ec_suspend_prepare() - Handle a suspend prepare operation for the ChromeOS EC device.
> + * @ec_dev: Device to suspend.
> + *
> + * This can be called by drivers to handle a suspend prepare stage of suspend.
> + *
> + * Return: 0 on success or negative error code.
Please update accordingly to reflect the fact.
> +/**
> + * cros_ec_suspend_late() - Handle a suspend late operation for the ChromeOS EC device.
> + * @ec_dev: Device to suspend.
> + *
> + * This can be called by drivers to handle a suspend late stage of suspend.
> + *
> + * Return: 0 on success or negative error code.
Ditto.
> + */
> +int cros_ec_suspend_late(struct cros_ec_device *ec_dev)
> +{
> + cros_ec_disable_irq(ec_dev);
> + return 0;
> +}
> +EXPORT_SYMBOL(cros_ec_suspend_late);
>
> +/**
> + * cros_ec_suspend() - Handle a suspend operation for the ChromeOS EC device.
> + * @ec_dev: Device to suspend.
> + *
> + * This can be called by drivers to handle a suspend event.
> + *
> + * Return: 0 on success or negative error code.
Ditto.
> +/**
> + * cros_ec_resume_early() - Handle a resume early operation for the ChromeOS EC device.
> + * @ec_dev: Device to resume.
> + *
> + * This can be called by drivers to handle a resume early stage of resume.
> + *
> + * Return: 0 on success or negative error code.
Ditto.
> + */
> +int cros_ec_resume_early(struct cros_ec_device *ec_dev)
> +{
> + cros_ec_enable_irq(ec_dev);
> + return 0;
> +}
> +EXPORT_SYMBOL(cros_ec_resume_early);
>
> +/**
> + * cros_ec_resume() - Handle a resume operation for the ChromeOS EC device.
> + * @ec_dev: Device to resume.
> + *
> + * This can be called by drivers to handle a resume event.
> + *
> + * Return: 0 on success or negative error code.
Ditto.
prev parent reply other threads:[~2023-10-25 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 15:58 [PATCH v3] platform/chrome: cros_ec_lpc: Separate host command and irq disable Lalith Rajendran
2023-10-25 0:23 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZThgEdJuxTmucKIe@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=lalithkraj@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=timvp@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).