From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Mark Hasemeyer" <markhas@chromium.org>,
"LKML" <linux-kernel@vger.kernel.org>
Cc: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Raul Rangel" <rrangel@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Alexandre TORGUE" <alexandre.torgue@st.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Baoquan He" <bhe@redhat.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Benson Leung" <bleung@chromium.org>,
"Bhanu Prakash Maiya" <bhanumaiya@chromium.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Daniel Scally" <djrscally@gmail.com>,
"David Gow" <davidgow@google.com>,
"Enric Balletbo i Serra" <eballetbo@gmail.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Lee Jones" <lee@kernel.org>, "Len Brown" <lenb@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Michal Simek" <michal.simek@amd.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Nick Hawkins" <nick.hawkins@hpe.com>,
"Prashant Malani" <pmalani@chromium.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rob Barnes" <robbarnes@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Stephen Boyd" <swboyd@chromium.org>,
"Takashi Iwai" <tiwai@suse.de>,
"Tony Lindgren" <tony@atomide.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wolfram Sang" <wsa@kernel.org>,
chrome-platform@lists.linux.dev,
cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it
Date: Fri, 16 Feb 2024 12:31:03 +0100 [thread overview]
Message-ID: <CZ6GWUQ73SSL.6HP29PU9Q7R@gmail.com> (raw)
In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
On Tue Dec 26, 2023 at 8:21 PM CET, Mark Hasemeyer wrote:
> Currently the cros_ec driver assumes that its associated interrupt is
> wake capable. This is an incorrect assumption as some Chromebooks use a
> separate wake pin, while others overload the interrupt for wake and IO.
> This patch train updates the driver to query the underlying ACPI/DT data
> to determine whether or not the IRQ should be enabled for wake.
>
> Both the device tree and ACPI systems have methods for reporting IRQ
> wake capability. In device tree based systems, a node can advertise
> itself as a 'wakeup-source'. In ACPI based systems, GpioInt and
> Interrupt resource descriptors can use the 'SharedAndWake' or
> 'ExclusiveAndWake' share types.
>
> Some logic is added to the platform, ACPI, and DT subsystems to more
> easily pipe wakeirq information up to the driver.
>
> Changes in v3:
> -Rebase on linux-next
> -See each patch for patch specific changes
>
> Changes in v2:
> -Rebase on linux-next
> -Add cover letter
> -See each patch for patch specific changes
>
> Mark Hasemeyer (24):
[...]
> ARM: dts: tegra: Enable cros-ec-spi as wake source
[...]
> arm64: dts: tegra: Enable cros-ec-spi as wake source
[...]
Both patches applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-02-16 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 24/24] platform/chrome: cros_ec: Use PM subsystem to manage wakeirq Mark Hasemeyer
2023-12-27 6:26 ` Tzung-Bi Shih
2023-12-27 20:45 ` Mark Hasemeyer
2023-12-27 17:34 ` Andy Shevchenko
2023-12-27 21:29 ` Mark Hasemeyer
2023-12-28 2:18 ` Tzung-Bi Shih
2024-02-14 17:57 ` (subset) [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Bjorn Andersson
2024-02-16 11:31 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZ6GWUQ73SSL.6HP29PU9Q7R@gmail.com \
--to=thierry.reding@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.torgue@st.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=andre.przywara@arm.com \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhanumaiya@chromium.org \
--cc=bhe@redhat.com \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=eballetbo@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=jonathanh@nvidia.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=markhas@chromium.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=nick.hawkins@hpe.com \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=robbarnes@google.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rrangel@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sudeep.holla@arm.com \
--cc=swboyd@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=tiwai@suse.de \
--cc=tony@atomide.com \
--cc=tzungbi@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wenst@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).