From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: bleung@chromium.org, tzungbi@kernel.org
Cc: groeck@chromium.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org,
Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: [PATCH 0/7] platform/chrome: Implement quickselect for median calculation
Date: Fri, 10 Nov 2023 02:54:32 +0800 [thread overview]
Message-ID: <20231109185439.1535962-1-visitorckw@gmail.com> (raw)
This patch series improves the performance of the
cros_ec_sensor_ring_median function. Currently, an inefficient sorting
algorithm (> O(n)) is used to find the median of an array. This series
replaces the sorting approach with the quickselect algorithm, achieving
an average time complexity of O(n).
The correctness and performance improvement have been verified through
a simple unit testing, including a micro-benchmark [1].
In addition to the algorithmic improvement, this series includes
several typo fixes to enhance the overall code quality and maintain
consistency.
--
[1]:
static void init_array(s64 *arr, size_t length, s64 seed)
{
for (int i = 0; i < length; i++) {
seed = (seed * 725861) % 6599;
arr[i] = seed;
}
}
static int quickselect_test(void)
{
s64 *arr;
s64 median_old, median_new;
ktime_t start, end;
s64 delta;
const size_t array_length = 1000;
const s64 seed = 1;
arr = kmalloc(array_length * sizeof(s64), GFP_KERNEL);
if (!arr)
return -ENOMEM;
init_array(arr, array_length, seed);
start = ktime_get();
median_old = cros_ec_sensor_ring_median(arr, array_length);
end = ktime_get();
delta = ktime_us_delta(end, start);
printk(KERN_ALERT "time of original function: %lld\n", delta);
init_array(arr, array_length, seed);
start = ktime_get();
median_new = cros_ec_sensor_ring_median_new(arr, array_length);
end = ktime_get();
delta = ktime_us_delta(end, start);
printk(KERN_ALERT "time of new function: %lld\n", delta);
kfree(arr);
/* return 0 on success */
return median_old != median_new;
}
/* Result:
* time of original function: 897
* time of new function: 16
*/
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
--
Kuan-Wei Chiu (7):
platform/chrome: Fix typo 'preceeds' in comment
platform/chrome: Fix typo 'perod' in comment
platform/chrome: Fix typo 'noone' in comment
platform/chrome: Fix typo 'lantency' in comment
platform/chrome: Fix typo 'kifo' in commet
platform/chrome: Fix typo 'change' in comment
platform/chrome: Implement quickselect for median calculation
.../platform/chrome/cros_ec_sensorhub_ring.c | 83 ++++++++++++++-----
1 file changed, 60 insertions(+), 23 deletions(-)
--
2.25.1
next reply other threads:[~2023-11-09 18:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 18:54 Kuan-Wei Chiu [this message]
2023-11-09 18:54 ` [PATCH 1/7] platform/chrome: Fix typo 'preceeds' in comment Kuan-Wei Chiu
2023-11-09 18:54 ` [PATCH 2/7] platform/chrome: Fix typo 'perod' " Kuan-Wei Chiu
2023-11-09 18:54 ` [PATCH 3/7] platform/chrome: Fix typo 'noone' " Kuan-Wei Chiu
2023-11-09 18:54 ` [PATCH 4/7] platform/chrome: Fix typo 'lantency' " Kuan-Wei Chiu
2023-11-09 18:54 ` [PATCH 5/7] platform/chrome: Fix typo 'kifo' in commet Kuan-Wei Chiu
2023-11-09 18:54 ` [PATCH 6/7] platform/chrome: Fix typo 'change' in comment Kuan-Wei Chiu
2023-11-09 18:54 ` [PATCH 7/7] platform/chrome: Implement quickselect for median calculation Kuan-Wei Chiu
2023-11-10 5:57 ` Tzung-Bi Shih
2023-11-10 5:58 ` [PATCH 0/7] " Tzung-Bi Shih
2023-11-10 14:52 ` Kuan-Wei Chiu
2023-11-10 16:52 ` [PATCH v2] platform/chrome: sensorhub: Fix typos Kuan-Wei Chiu
2023-11-10 18:34 ` Randy Dunlap
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-14 6:00 ` patchwork-bot+chrome-platform
2023-11-10 16:53 ` [PATCH v2] platform/chrome: sensorhub: Implement quickselect for median calculation Kuan-Wei Chiu
2023-11-13 4:50 ` patchwork-bot+chrome-platform
2023-11-14 6:00 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109185439.1535962-1-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).