From: Rob Barnes <robbarnes@google.com>
To: chrome-platform@lists.linux.dev
Cc: gwendal@chromium.org, groweck@chromium.org,
Rob Barnes <robbarnes@google.com>
Subject: [PATCH] drivers/cros_ec: Reduce log polling period to 2s
Date: Thu, 21 Sep 2023 14:19:35 +0000 [thread overview]
Message-ID: <20230921141935.3973069-1-robbarnes@google.com> (raw)
Lowering the log polling interval to 2 seconds provides two advantages:
1. Minimizes the risk of EC internal log buffer overfilling and truncating.
2. Yields more recent logs prior to a crash, facilitating easier debugging.
Signed-off-by: Rob Barnes <robbarnes@google.com>
---
drivers/platform/chrome/cros_ec_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
index 9044c6bab770c..c96493504127d 100644
--- a/drivers/platform/chrome/cros_ec_debugfs.c
+++ b/drivers/platform/chrome/cros_ec_debugfs.c
@@ -21,7 +21,7 @@
#define LOG_SHIFT 14
#define LOG_SIZE (1 << LOG_SHIFT)
-#define LOG_POLL_SEC 10
+#define LOG_POLL_SEC 2
#define CIRC_ADD(idx, size, value) (((idx) + (value)) & ((size) - 1))
--
2.42.0.459.ge4e396fd5e-goog
next reply other threads:[~2023-09-21 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:19 Rob Barnes [this message]
2023-09-23 8:41 ` [PATCH] drivers/cros_ec: Reduce log polling period to 2s Tzung-Bi Shih
2023-09-26 18:57 ` Rob Barnes
2023-09-28 7:07 ` Tzung-Bi Shih
2024-05-02 17:13 ` Rob Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921141935.3973069-1-robbarnes@google.com \
--to=robbarnes@google.com \
--cc=chrome-platform@lists.linux.dev \
--cc=groweck@chromium.org \
--cc=gwendal@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).