From: patchwork-bot+chrome-platform@kernel.org
To: Noah Loomans <noah@noahloomans.com>
Cc: bhanumaiya@chromium.org, bleung@chromium.org, tzungbi@kernel.org,
groeck@chromium.org, robertzieba@google.com,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_uart: properly fix race condition
Date: Wed, 24 Apr 2024 08:52:50 +0000 [thread overview]
Message-ID: <171394877035.3441.2924475068794719398.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240410182618.169042-2-noah@noahloomans.com>
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Wed, 10 Apr 2024 20:26:19 +0200 you wrote:
> The cros_ec_uart_probe() function calls devm_serdev_device_open() before
> it calls serdev_device_set_client_ops(). This can trigger a NULL pointer
> dereference:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000000
> ...
> CPU: 5 PID: 103 Comm: kworker/u16:3 Not tainted 6.8.4-zen1-1-zen #1 4a88f2661038c2a3bb69aa70fb41a5735338823c
> Hardware name: Google Morphius/Morphius, BIOS MrChromebox-4.22.2-1-g2a93624aebf 01/22/2024
> Workqueue: events_unbound flush_to_ldisc
> RIP: 0010:ttyport_receive_buf+0x3f/0xf0
> ...
> Call Trace:
> <TASK>
> ? __die+0x10f/0x120
> ? page_fault_oops+0x171/0x4e0
> ? srso_return_thunk+0x5/0x5f
> ? exc_page_fault+0x7f/0x180
> ? asm_exc_page_fault+0x26/0x30
> ? ttyport_receive_buf+0x3f/0xf0
> flush_to_ldisc+0x9b/0x1c0
> process_one_work+0x17b/0x340
> worker_thread+0x301/0x490
> ? __pfx_worker_thread+0x10/0x10
> kthread+0xe8/0x120
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x34/0x50
> ? __pfx_kthread+0x10/0x10
> ret_from_fork_asm+0x1b/0x30
> </TASK>
>
> [...]
Here is the summary with links:
- platform/chrome: cros_ec_uart: properly fix race condition
https://git.kernel.org/chrome-platform/c/5e700b384ec1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-04-24 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 18:26 [PATCH] platform/chrome: cros_ec_uart: properly fix race condition Noah Loomans
2024-04-10 19:48 ` Guenter Roeck
2024-04-10 22:06 ` Noah Loomans
2024-04-11 2:18 ` Tzung-Bi Shih
2024-04-11 2:26 ` Guenter Roeck
2024-04-11 16:08 ` Noah Loomans
2024-04-11 16:08 ` Noah Loomans
2024-04-24 8:51 ` patchwork-bot+chrome-platform
2024-04-24 8:52 ` patchwork-bot+chrome-platform [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171394877035.3441.2924475068794719398.git-patchwork-notify@kernel.org \
--to=patchwork-bot+chrome-platform@kernel.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noah@noahloomans.com \
--cc=robertzieba@google.com \
--cc=stable@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).