chrome-platform.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Even Xu <even.xu@intel.com>
To: jikos@kernel.org, srinivas.pandruvada@linux.intel.com,
	bleung@chromium.org, tzungbi@kernel.org, groeck@chromium.org,
	linux-input@vger.kernel.org, chrome-platform@lists.linux.dev
Cc: Even Xu <even.xu@intel.com>
Subject: [PATCH 0/4] Simplify ISHTP client interface
Date: Tue,  5 Dec 2023 09:50:29 +0800	[thread overview]
Message-ID: <1701741033-26222-1-git-send-email-even.xu@intel.com> (raw)

There are three ISHTP clients, they have same ISHTP interface to
connect, reset and disconnect. Also there are multiple steps for
connect, reset and disconnect.

Simplify multiple steps by creating two helper functions. This will
simplify code flow and also avoid code duplication. Also this removes
memory allocation calls during reset, by using these helper functions.

No functional changes are expected with this series.

Even Xu (4):
  HID: Intel-ish-hid: Ishtp: Add helper functions for client connection
  HID: intel-ish-hid: ishtp-hid-client: use helper functions for
    connection
  HID: intel-ish-hid: ishtp-fw-loader: use helper functions for
    connection
  platform: chrome: cros_ec_ishtp: use helper functions for connection

 drivers/hid/intel-ish-hid/ishtp-fw-loader.c  |  60 ++-------
 drivers/hid/intel-ish-hid/ishtp-hid-client.c |  63 ++-------
 drivers/hid/intel-ish-hid/ishtp/client.c     | 185 +++++++++++++++++++++++++--
 drivers/platform/chrome/cros_ec_ishtp.c      |  74 +++--------
 include/linux/intel-ish-client-if.h          |   3 +
 5 files changed, 217 insertions(+), 168 deletions(-)

-- 
2.7.4


             reply	other threads:[~2023-12-05  1:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05  1:50 Even Xu [this message]
2023-12-05  1:50 ` [PATCH 1/4] HID: Intel-ish-hid: Ishtp: Add helper functions for client connection Even Xu
2023-12-05  1:50 ` [PATCH 2/4] HID: intel-ish-hid: ishtp-hid-client: use helper functions for connection Even Xu
2023-12-05  1:50 ` [PATCH 3/4] HID: intel-ish-hid: ishtp-fw-loader: " Even Xu
2023-12-05  1:50 ` [PATCH 4/4] platform: chrome: cros_ec_ishtp: " Even Xu
2023-12-06  3:33   ` Tzung-Bi Shih
2023-12-06  3:53     ` Xu, Even
2023-12-06 10:34     ` Jiri Kosina
2023-12-08  0:38       ` Xu, Even

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1701741033-26222-1-git-send-email-even.xu@intel.com \
    --to=even.xu@intel.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).