From: xiujianfeng <xiujianfeng@huawei.com>
To: Klara Modin <klarasmodin@gmail.com>, <longman@redhat.com>,
<lizefan.x@bytedance.com>, <tj@kernel.org>, <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] cgroup/cpuset: Statically initialize more members of top_cpuset
Date: Wed, 24 Apr 2024 08:56:47 +0800 [thread overview]
Message-ID: <a94e7b2f-0c22-f9bd-236c-d542958b6934@huawei.com> (raw)
In-Reply-To: <f2edf788-6ff3-43b1-9445-ac237e7910ac@gmail.com>
On 2024/4/24 3:21, Klara Modin wrote:
> Hi,
>
> On 2024-04-20 11:46, Xiu Jianfeng wrote:
>> Initializing top_cpuset.relax_domain_level and setting
>> CS_SCHED_LOAD_BALANCE to top_cpuset.flags in cpuset_init() could be
>> completed at the time of top_cpuset definition by compiler.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>> ---
>> kernel/cgroup/cpuset.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
>> index d8d3439eda4e..e70008a1d86a 100644
>> --- a/kernel/cgroup/cpuset.c
>> +++ b/kernel/cgroup/cpuset.c
>> @@ -369,8 +369,9 @@ static inline void notify_partition_change(struct
>> cpuset *cs, int old_prs)
>> static struct cpuset top_cpuset = {
>> .flags = ((1 << CS_ONLINE) | (1 << CS_CPU_EXCLUSIVE) |
>> - (1 << CS_MEM_EXCLUSIVE)),
>> + (1 << CS_MEM_EXCLUSIVE) | (1 < CS_SCHED_LOAD_BALANCE)),
>
> You dropped a '<' for the bitwise shift, this causes bad cpu utilization
> for me.
Oops, that's bad, I'm sorry for that!
>
>> .partition_root_state = PRS_ROOT,
>> + .relax_domain_level = -1,
>> .remote_sibling = LIST_HEAD_INIT(top_cpuset.remote_sibling),
>> };
>> @@ -4309,8 +4310,6 @@ int __init cpuset_init(void)
>> nodes_setall(top_cpuset.effective_mems);
>> fmeter_init(&top_cpuset.fmeter);
>> - set_bit(CS_SCHED_LOAD_BALANCE, &top_cpuset.flags);
>> - top_cpuset.relax_domain_level = -1;
>> INIT_LIST_HEAD(&remote_children);
>> BUG_ON(!alloc_cpumask_var(&cpus_attach, GFP_KERNEL));
>
> Kind regards,
> Klara Modin
prev parent reply other threads:[~2024-04-24 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 9:46 [PATCH -next] cgroup/cpuset: Statically initialize more members of top_cpuset Xiu Jianfeng
2024-04-22 18:34 ` Waiman Long
2024-04-22 19:52 ` Tejun Heo
2024-04-23 19:21 ` Klara Modin
2024-04-23 19:50 ` Waiman Long
2024-04-23 19:59 ` Klara Modin
2024-04-24 0:56 ` xiujianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a94e7b2f-0c22-f9bd-236c-d542958b6934@huawei.com \
--to=xiujianfeng@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=klarasmodin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).