From: Dan Schatzberg <schatzberg.dan@gmail.com>
To: Yu Zhao <yuzhao@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Yosry Ahmed <yosryahmed@google.com>, Huan Yang <link@vivo.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Jonathan Corbet <corbet@lwn.net>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
SeongJae Park <sj@kernel.org>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
Nhat Pham <nphamcs@gmail.com>, Yue Zhao <findns94@gmail.com>
Subject: Re: [PATCH v5 2/2] mm: add swapiness= arg to memory.reclaim
Date: Wed, 3 Jan 2024 10:19:06 -0500 [thread overview]
Message-ID: <ZZV66igbHQShq7-k@dschatzberg-fedora-PC0Y6AEN> (raw)
In-Reply-To: <CAOUHufaTDcLNipHQC3sJuoOVcCkKnmzHt=tiiZrOxmOg5EUVYA@mail.gmail.com>
On Tue, Jan 02, 2024 at 05:27:18PM -0700, Yu Zhao wrote:
[...]
> > Helper aside, I disagree with this point about coupling with the
> > proactive flag.
>
> Sure. But I would like to hear a *concrete* counterexample.
>
> > The fact that the only user currently is proactive
> > reclaim
>
> Yes, that's a fact, and we should make the decision based on the
> current known facts.
>
> > doesn't imply to me that the interface (in scan_control)
> > should be coupled to the use-case.
>
> Future always has its uncertainty which I would not worry so much about.
>
> > It's easier to reason about a
> > swappiness field that overrides swappiness for all scans that set it
> > regardless of the users.
>
> For example? And how likely would that happen in the next few years?
My argument isn't that making the interface more generic will be
worthwhile due to some future use-case. Rather my argument is that
making the interface more generic makes the code simpler. All else
being equal, having sc->swappiness behave the same regardless of
sc->proactive makes vmscan.c and struct scan_control easier to follow.
That being said - I'm fine with conceding this point - particularly
since both you and Michal appear to feel similarly. I'll make the
corresponding change and send out a new version.
next prev parent reply other threads:[~2024-01-03 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 15:26 [PATCH v5 0/2] Add swappiness argument to memory.reclaim Dan Schatzberg
2023-12-20 15:26 ` [PATCH v5 1/2] mm: add defines for min/max swappiness Dan Schatzberg
2023-12-21 2:01 ` Nhat Pham
2023-12-22 4:38 ` David Rientjes
2023-12-24 17:14 ` Chris Li
2023-12-20 15:26 ` [PATCH v5 2/2] mm: add swapiness= arg to memory.reclaim Dan Schatzberg
2023-12-21 9:29 ` Michal Hocko
2024-01-02 17:43 ` Dan Schatzberg
2024-01-03 8:59 ` Michal Hocko
2023-12-22 4:38 ` David Rientjes
2023-12-22 5:31 ` Yu Zhao
2024-01-02 15:21 ` Dan Schatzberg
2024-01-03 0:27 ` Yu Zhao
2024-01-03 15:19 ` Dan Schatzberg [this message]
2024-01-03 9:03 ` Michal Hocko
2023-12-24 17:21 ` Chris Li
2024-01-02 22:42 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZV66igbHQShq7-k@dschatzberg-fedora-PC0Y6AEN \
--to=schatzberg.dan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=findns94@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=link@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=sj@kernel.org \
--cc=tj@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).