From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: tj@kernel.org, axboe@kernel.dk, josef@toxicpanda.com,
shli@fb.com, linux-block@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
Date: Tue, 26 Mar 2024 14:57:19 +0000 [thread overview]
Message-ID: <98859b45-e86a-40d4-8cfd-8cf63db3cb14@oracle.com> (raw)
In-Reply-To: <ZgLgedPipnZuyHCA@infradead.org>
On 26/03/2024 14:49, Christoph Hellwig wrote:
>> Here's how the current code could look (using only seq_printf):
> That looks much better, thanks.
ok, I'll put it in a formal patch. It would be nice to put purely a
"fix" for stable, but no one else has complained about this old warning
AFAIK.
Thanks,
John
prev parent reply other threads:[~2024-03-26 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 12:19 [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit() John Garry
2024-03-26 7:03 ` Christoph Hellwig
2024-03-26 8:46 ` John Garry
2024-03-26 14:49 ` Christoph Hellwig
2024-03-26 14:57 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98859b45-e86a-40d4-8cfd-8cf63db3cb14@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).