From: xiujianfeng <xiujianfeng@huawei.com>
To: Waiman Long <longman@redhat.com>, <lizefan.x@bytedance.com>,
<tj@kernel.org>, <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] cgroup/cpuset: Avoid clearing CS_SCHED_LOAD_BALANCE twice
Date: Tue, 23 Apr 2024 09:40:09 +0800 [thread overview]
Message-ID: <8bfc0013-8268-0e7e-1ee0-99ad04b0b467@huawei.com> (raw)
In-Reply-To: <f2fc2eb8-44e0-4805-86c0-f9062380b3e8@redhat.com>
On 2024/4/23 2:38, Waiman Long wrote:
> On 4/20/24 05:47, Xiu Jianfeng wrote:
>> In cpuset_css_online(), CS_SCHED_LOAD_BALANCE has been cleared in the
>> is_in_v2_mode() case under the same condition, don't do it twice.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>> ---
>> kernel/cgroup/cpuset.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
>> index e70008a1d86a..159525cdaeb9 100644
>> --- a/kernel/cgroup/cpuset.c
>> +++ b/kernel/cgroup/cpuset.c
>> @@ -4059,13 +4059,6 @@ static int cpuset_css_online(struct
>> cgroup_subsys_state *css)
>> clear_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);
>> }
>> - /*
>> - * For v2, clear CS_SCHED_LOAD_BALANCE if parent is isolated
>> - */
>> - if (cgroup_subsys_on_dfl(cpuset_cgrp_subsys) &&
>> - !is_sched_load_balance(parent))
>> - clear_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);
>> -
>> spin_unlock_irq(&callback_lock);
>> if (!test_bit(CGRP_CPUSET_CLONE_CHILDREN, &css->cgroup->flags))
>
> Thanks for catching this duplication.
>
> Could you remove the check inside is_in_v2_mode() instead?
> is_in_v2_mode() can be true for cgroup v1 if the"cpuset_v2_mode" mount
> option is specified. That balance flag change isn't appropriate for this
> particular case.
Sure, thanks for explanation, will do in v2.
>
> Thanks,
> Longman
>
prev parent reply other threads:[~2024-04-23 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 9:47 [PATCH -next] cgroup/cpuset: Avoid clearing CS_SCHED_LOAD_BALANCE twice Xiu Jianfeng
2024-04-22 18:38 ` Waiman Long
2024-04-23 1:40 ` xiujianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bfc0013-8268-0e7e-1ee0-99ad04b0b467@huawei.com \
--to=xiujianfeng@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).